| commit | 08c63e1bcf15afe627e1a7381f5a580fc345ba9c | [log] [tgz] |
|---|---|---|
| author | Kamil Musin <kamilm@google.com> | Fri Oct 25 13:16:12 2024 +0200 |
| committer | Paladox none <thomasmulhall410@yahoo.com> | Fri Oct 25 12:41:43 2024 +0000 |
| tree | 30e3b28f4e971b526c02c9bcb6153004eea1102f | |
| parent | 797596b88111dcb3282d20936f3abba34c9c8aac [diff] |
Update attention set behaviour when commenting on a thread. Previously the rule worked like this: When reply comment is added on a thread, every previous commenters (except for the user leaving a reply) on the thread is added if: - They are not the user leaving a reply - If thread is unresolved - If thread is resolved, and the commenter have not voted Code-Review with a maximum vote yet. After this change: - If change owner replies and thread is unresolved: every commenter on the thread is brought back to attention set - If change owner replies and thread is resolved: only commenters that haven't voted Code-Review are brought to attention set - If reviewer replies and thread is unresolved, only bring owner to attention set - If reviewer replies and thread is resolved, bring all other commenters who haven't voted Code-Review to attention set. The logic doesn't account for users who don't have permissions to leave a max CR vote. But this is the same for the current state as well. This can be a further improvement in the future. This is FE-only change, this will affect only comments published via Web-UI. There will be a corresponding check to the BE logic in a subsequent change. Release-Notes: Attention set when commenting on a thread takes into account owner and unresolved status. Google-Bug-Id: b/347949247 Change-Id: I849a8dda069c74d97c75ce86706f35ea64717670 (cherry picked from commit f42012d837c1e15e0a598f41b66c999bae6ecb67)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.