| commit | 140fadf8cae80cca43d0a3e4b6c71717360b807a | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Wed Jun 12 12:10:56 2024 +0000 |
| committer | Ben Rohlfs <brohlfs@google.com> | Thu Jun 13 12:29:01 2024 +0200 |
| tree | b8ba123038c11b4034f725df53c1cb949561db63 | |
| parent | d1a9005cc2dba457ec480da869a974c2678cf908 [diff] |
Compute diff URLs in the view model This rolls forward change 429437. Compare against patchset 1 to see what has changed compared to the version of the change that had to be rolled back. The reason for rolling back was that we actually have to provide the `patchNum` to the view model. For diff views the specific patchNum has to be provided, even if your choice is the "latest" patch num. That is different from the change overview page, which allows the patchNum in the URL to be undefined. Original commit message: This fixes a bug where `checksPatchset` would be reset when navigating to a diff view. Generally, when we are constsructing a diff URL we are typically interested into computing a URL relative to the current state. We do not want to look up and set all current view properties in every code location that creates a diff URL. So we move the construction of diff URLs into the view model itself and just provide the delta as an override. Release-Notes: skip Google-Bug-Id: b/345851627 Change-Id: If874a91d05800a06efe800e656567134915b3013
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.