commit 4492acba07e4e5e43fea0b527c3c0a9abc6c4e18
author Becky Siegel <beckysiegel@google.com> Thu Mar 29 21:58:29 2018 +0000
committer Paladox <thomasmulhall410@yahoo.com> Thu Mar 29 23:46:21 2018 +0100
tree fa5fadeeaee70a4d1b84d5d47ba7701e5317005b
parent db05d1a550839bb839bb5c6674d945c1f34899b6

Add a check for name in Firefox/Safari

Change-Id: I89649cb9415d34b769a54a277d51ce722ffe146b

polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-public-js-api.js

diff --git a/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-public-js-api.js b/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-public-js-api.js
index d3eee44..ac4129f 100644
--- a/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-public-js-api.js
+++ b/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-public-js-api.js
@@ -326,7 +326,12 @@
       console.warn(`${name} install failed: ${e.name}: ${e.message}`);
     }
     // Don't double count plugins that may have an html and js install.
-    if (!existingPlugin) {
+    // TODO(beckysiegel) remove name check once name issue is resolved.
+    // If there isn't a name, it's due to an issue with the polyfill for
+    // html imports in Safari/Firefox. In this case, other plugin related
+    // features may still be broken, but still make sure to call.
+    // _pluginInstalled.
+    if (!name || !existingPlugin) {
       Gerrit._pluginInstalled();
     }
   };