Change access level for ReplacePatchSetChangeEmailDecoratorImpl Changing private to protected would allow to inherit from this class, when overriding to reduce duplication. Google-Bug-Id: b/266904943 Release-Notes: skip Change-Id: I3b1ee397507ae0e1cba4d5fff2975a6af1746719
diff --git a/java/com/google/gerrit/server/mail/send/ReplacePatchSetChangeEmailDecoratorImpl.java b/java/com/google/gerrit/server/mail/send/ReplacePatchSetChangeEmailDecoratorImpl.java index 4a0fdb4..08b841b 100644 --- a/java/com/google/gerrit/server/mail/send/ReplacePatchSetChangeEmailDecoratorImpl.java +++ b/java/com/google/gerrit/server/mail/send/ReplacePatchSetChangeEmailDecoratorImpl.java
@@ -48,18 +48,19 @@ implements ReplacePatchSetChangeEmailDecorator { private static final FluentLogger logger = FluentLogger.forEnclosingClass(); - private final EmailArguments args; - private OutgoingEmail email; - private ChangeEmail changeEmail; - private final Set<Account.Id> reviewers = new HashSet<>(); - private final Set<Account.Id> extraCC = new HashSet<>(); - private final ChangeKind changeKind; - private final Set<PatchSetApproval> outdatedApprovals = new HashSet<>(); - private final Supplier<Map<SubmitRequirement, SubmitRequirementResult>> + protected final EmailArguments args; + protected OutgoingEmail email; + protected ChangeEmail changeEmail; + protected final Set<Account.Id> reviewers = new HashSet<>(); + protected final Set<Account.Id> extraCC = new HashSet<>(); + protected final ChangeKind changeKind; + protected final Set<PatchSetApproval> outdatedApprovals = new HashSet<>(); + protected final Supplier<Map<SubmitRequirement, SubmitRequirementResult>> preUpdateSubmitRequirementResultsSupplier; - private final Map<SubmitRequirement, SubmitRequirementResult> postUpdateSubmitRequirementResults; + protected final Map<SubmitRequirement, SubmitRequirementResult> + postUpdateSubmitRequirementResults; - ReplacePatchSetChangeEmailDecoratorImpl( + public ReplacePatchSetChangeEmailDecoratorImpl( @Provided EmailArguments args, Project.NameKey project, Change.Id changeId, @@ -123,7 +124,7 @@ } @Nullable - private ImmutableList<String> getReviewerNames() { + protected ImmutableList<String> getReviewerNames() { List<String> names = new ArrayList<>(); for (Account.Id id : reviewers) { if (id.equals(email.getFrom())) { @@ -137,7 +138,7 @@ return names.stream().sorted().collect(toImmutableList()); } - private ImmutableList<String> formatOutdatedApprovals() { + protected ImmutableList<String> formatOutdatedApprovals() { return outdatedApprovals.stream() .map( outdatedApproval ->