commit | 42c1a45f81a8c45966b47622fd2dad2f37fc1439 | [log] [tgz] |
---|---|---|
author | Frank Borden <frankborden@google.com> | Thu Aug 11 16:27:20 2022 +0200 |
committer | Frank Borden <frankborden@google.com> | Tue Aug 16 09:26:31 2022 +0200 |
tree | 576aec7ac2eb01661ac8ea128dba5ca00a4c388f | |
parent | 24623fc37e81eff584c7bbd18e3aac7f545627cf [diff] |
Web Dev Server Motivation: - The current server.go file has been a maintenance burden when adding new dependencies since we must write and update complex regexes to resolve node_modules paths ourselves. Web Dev Server also offers a performance boost on startup and after saving files. User differences: - still run command: `> yarn start` from the project root directory, and server runs on same port as before. - instant startup since there is no need to invoke bazel or pre-compile typescript files. - no need to wait for tsc watcher before reloading. Esbuild is fast enough to compile files on the fly as requested. - No type checking is done by default. Users can separately run command: `> yarn compile:watch`, or we can consider running it in same output window with package like `concurrently` or `npm-run-all`. File changes: - web-dev-server.config.mjs - configures plugins and middlewares to play nice with Gerrit FE Helper. See file comments. - Update imports of lit directives and decorators to end in .js to match lit's export map. This is because the dev server's node resolver is more strict than our previous one. This is done in many files. https://github.com/lit/lit/blob/main/packages/lit/package.json#L19 - Update import/export of types. Esbuild does not do type checking unlike tsc and doesn't realize that an import is only for a type. Typescript has 'import type {...}' and export type '{...}' syntax for this. This is done in a few files. - page-wrapper-utils.ts - convert page.js import to use esm instead of importing onto global window object. This prevents workaround needed like we have in karma and rollup config. Removed from gr-app-global-var-init.ts as well. Release-Notes: skip Google-Bug-Id: b/199389603 Change-Id: I0840563c4c2eec46be2461bd10e123e5675cc12b
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.