| commit | 428141251253438aeb51585907f87f7973a0b520 | [log] [tgz] |
|---|---|---|
| author | Shawn O. Pearce <sop@google.com> | Thu Jan 29 10:24:33 2009 -0800 |
| committer | Shawn O. Pearce <sop@google.com> | Thu Jan 29 10:24:33 2009 -0800 |
| tree | 8942413a014a148c33af2fc1e2e1af087b5d934a | |
| parent | cff7c1dcc034fe54545349980f06b4bf2fffd2e6 [diff] |
Don't auto-approve changes when they are uploaded The entire point of the code review systems is to have another party beyond the uploader review the changes to determine they are suitable for inclusion, and set the approval bits onto the change record. Automatically approving your own changes reduces the value of this 3rd party review. Bug: GERRIT-56 Signed-off-by: Shawn O. Pearce <sop@google.com>