Remove FireBehavior imports and get rid of global test helpers This change removes all imports of fire-behavior.js (usages were removed before in a separate change). Also, change moves some global test helpers to the test-utils.js file and imports them where they are used. Change-Id: I25a85dcdfcb5fdfe7251fc166d1747fab0503af3
diff --git a/polygerrit-ui/app/.eslintrc.js b/polygerrit-ui/app/.eslintrc.js index 5e4d9b8..57b9262 100644 --- a/polygerrit-ui/app/.eslintrc.js +++ b/polygerrit-ui/app/.eslintrc.js
@@ -251,13 +251,6 @@ "suiteSetup": "readonly", "teardown": "readonly", "test": "readonly", - // Polygerrit global variables. - // You must not add anything new in this list! - // Instead export variables from modules - // TODO(dmfilippov): Remove global variables from polygerrit - "isHidden": "readonly", - "mockPromise": "readonly", - } }, {
diff --git a/polygerrit-ui/app/behaviors/fire-behavior/fire-behavior.js b/polygerrit-ui/app/behaviors/fire-behavior/fire-behavior.js index e656cc4..88c8835 100644 --- a/polygerrit-ui/app/behaviors/fire-behavior/fire-behavior.js +++ b/polygerrit-ui/app/behaviors/fire-behavior/fire-behavior.js
@@ -14,57 +14,42 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -(function(window) { - 'use strict'; - window.Gerrit = window.Gerrit || {}; +/** @polymerBehavior Gerrit.FireBehavior */ +export const FireBehavior = { + /** + * Dispatches a custom event with an optional detail value. + * + * @param {string} type Name of event type. + * @param {*=} detail Detail value containing event-specific + * payload. + * @param {{ bubbles: (boolean|undefined), cancelable: (boolean|undefined), + * composed: (boolean|undefined) }=} + * options Object specifying options. These may include: + * `bubbles` (boolean, defaults to `true`), + * `cancelable` (boolean, defaults to false), and + * `composed` (boolean, defaults to true). + * @return {!Event} The new event that was fired. + * @override + */ + fire(type, detail, options) { + console.warn('\'fire\' is deprecated, please use dispatchEvent instead!'); + options = options || {}; + detail = (detail === null || detail === undefined) ? {} : detail; + const event = new Event(type, { + bubbles: options.bubbles === undefined ? true : options.bubbles, + cancelable: Boolean(options.cancelable), + composed: options.composed === undefined ? true: options.composed, + }); + event.detail = detail; + this.dispatchEvent(event); + return event; + }, +}; - /** @polymerBehavior Gerrit.FireBehavior */ - Gerrit.FireBehavior = { - /** - * Dispatches a custom event with an optional detail value. - * - * @param {string} type Name of event type. - * @param {*=} detail Detail value containing event-specific - * payload. - * @param {{ bubbles: (boolean|undefined), cancelable: (boolean|undefined), - * composed: (boolean|undefined) }=} - * options Object specifying options. These may include: - * `bubbles` (boolean, defaults to `true`), - * `cancelable` (boolean, defaults to false), and - * `composed` (boolean, defaults to true). - * @return {!Event} The new event that was fired. - * @override - */ - fire(type, detail, options) { - console.warn('\'fire\' is deprecated, please use dispatchEvent instead!'); - options = options || {}; - detail = (detail === null || detail === undefined) ? {} : detail; - const event = new Event(type, { - bubbles: options.bubbles === undefined ? true : options.bubbles, - cancelable: Boolean(options.cancelable), - composed: options.composed === undefined ? true: options.composed, - }); - event.detail = detail; - this.dispatchEvent(event); - return event; - }, - }; - - // eslint-disable-next-line no-unused-vars - function defineEmptyMixin() { - // This is a temporary function. - // Polymer linter doesn't process correctly the following code: - // class MyElement extends Polymer.mixinBehaviors([legacyBehaviors], ...) {...} - // To workaround this issue, the mock mixin is declared in this method. - // In the following changes, legacy behaviors will be converted to mixins. - - /** - * @polymer - * @mixinFunction - */ - Gerrit.FireMixin = base => - class extends base { - }; - } -})(window); +// TODO(dmfilippov) Remove the following lines with assignments +// Plugins can use the behavior because it was accessible with +// the global Gerrit... variable. To avoid breaking changes in plugins +// temporary assign global variables. +window.Gerrit = window.Gerrit || {}; +window.Gerrit.FireBehavior = FireBehavior;
diff --git a/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js b/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js index 17b0549..250f349 100644 --- a/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js +++ b/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js
@@ -15,8 +15,6 @@ * limitations under the License. */ import '../../../scripts/bundled-polymer.js'; - -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-access-behavior/gr-access-behavior.js'; import '@polymer/iron-input/iron-input.js'; import '../../../styles/gr-form-styles.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.js b/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.js index ecb37ad..2f50fe7 100644 --- a/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.js +++ b/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-list-view-behavior/gr-list-view-behavior.js'; import '../../../styles/gr-table-styles.js'; import '../../../styles/shared-styles.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.js b/polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.js index a0170b6..b6b21bd 100644 --- a/polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.js +++ b/polygerrit-ui/app/elements/admin/gr-confirm-delete-item-dialog/gr-confirm-delete-item-dialog.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../shared/gr-dialog/gr-dialog.js'; import '../../../styles/shared-styles.js'; import {GestureEventListeners} from '@polymer/polymer/lib/mixins/gesture-event-listeners.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js index ce2c2bd..f54e3b5 100644 --- a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js +++ b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js
@@ -18,7 +18,6 @@ import '@polymer/iron-input/iron-input.js'; import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-url-encoding-behavior/gr-url-encoding-behavior.js'; import '../../../styles/gr-form-styles.js'; import '../../../styles/shared-styles.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.js b/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.js index 0751ee4..b164d2f 100644 --- a/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.js +++ b/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.js
@@ -17,7 +17,6 @@ import '../../../behaviors/gr-list-view-behavior/gr-list-view-behavior.js'; import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/gr-table-styles.js'; import '../../../styles/shared-styles.js'; import '../../core/gr-navigation/gr-navigation.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.js b/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.js index 169c79f..acc2ba5 100644 --- a/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.js +++ b/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.js
@@ -15,7 +15,6 @@ * limitations under the License. */ -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-url-encoding-behavior/gr-url-encoding-behavior.js'; import '../../../scripts/bundled-polymer.js'; import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-group/gr-group.js b/polygerrit-ui/app/elements/admin/gr-group/gr-group.js index d2d3b7c..fc38c12 100644 --- a/polygerrit-ui/app/elements/admin/gr-group/gr-group.js +++ b/polygerrit-ui/app/elements/admin/gr-group/gr-group.js
@@ -14,7 +14,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../scripts/bundled-polymer.js'; import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.js b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.js index 630384c..3ab024f 100644 --- a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.js +++ b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-access-behavior/gr-access-behavior.js'; import '@polymer/paper-toggle-button/paper-toggle-button.js'; import '../../../styles/gr-form-styles.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.js b/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.js index 7b9f0da..36cde94 100644 --- a/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.js +++ b/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-list-view-behavior/gr-list-view-behavior.js'; import '../../../styles/gr-table-styles.js'; import '../../../styles/shared-styles.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js b/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js index b127534..022ff70 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js +++ b/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-access-behavior/gr-access-behavior.js'; import '../../../behaviors/gr-url-encoding-behavior/gr-url-encoding-behavior.js'; import '../../../styles/gr-menu-page-styles.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.js b/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.js index ba6b80b..cbe0d0a 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.js +++ b/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.js
@@ -17,7 +17,6 @@ import '../../../scripts/bundled-polymer.js'; import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/gr-form-styles.js'; import '../../../styles/gr-subpage-styles.js'; import '../../../styles/shared-styles.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.js b/polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.js index e7db26e..cb72a18 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.js +++ b/polygerrit-ui/app/elements/admin/gr-repo-dashboards/gr-repo-dashboards.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import '../../core/gr-navigation/gr-navigation.js'; import '../../shared/gr-rest-api-interface/gr-rest-api-interface.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.js b/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.js index ac4b9da..9bc9124 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.js +++ b/polygerrit-ui/app/elements/admin/gr-repo-detail-list/gr-repo-detail-list.js
@@ -19,7 +19,6 @@ import '../../../behaviors/gr-url-encoding-behavior/gr-url-encoding-behavior.js'; import '@polymer/iron-input/iron-input.js'; import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/gr-form-styles.js'; import '../../../styles/gr-table-styles.js'; import '../../../styles/shared-styles.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.js b/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.js index 5950664..cfc4015 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.js +++ b/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.js
@@ -18,7 +18,6 @@ import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js'; import '@polymer/iron-input/iron-input.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../plugins/gr-endpoint-decorator/gr-endpoint-decorator.js'; import '../../plugins/gr-endpoint-param/gr-endpoint-param.js'; import '../../shared/gr-download-commands/gr-download-commands.js';
diff --git a/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.js b/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.js index 0060256..5881cd0 100644 --- a/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.js +++ b/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.js
@@ -17,7 +17,6 @@ import '../../../scripts/bundled-polymer.js'; import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-access-behavior/gr-access-behavior.js'; import '../../../behaviors/gr-url-encoding-behavior/gr-url-encoding-behavior.js'; import '../../../styles/gr-form-styles.js';
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js index 8a63102..ff5e0a4 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js
@@ -17,7 +17,6 @@ import '../../../behaviors/gr-url-encoding-behavior/gr-url-encoding-behavior.js'; import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../core/gr-navigation/gr-navigation.js'; import '../../shared/gr-icons/gr-icons.js'; import '../../shared/gr-rest-api-interface/gr-rest-api-interface.js';
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js index a72faea..5f7467b 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js +++ b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js
@@ -20,7 +20,6 @@ import '../../../behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js'; import '../../../behaviors/rest-client-behavior/rest-client-behavior.js'; import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/gr-change-list-styles.js'; import '../../core/gr-navigation/gr-navigation.js'; import '../../shared/gr-cursor-manager/gr-cursor-manager.js';
diff --git a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js index fabcdad..0ec5e0a 100644 --- a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js +++ b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/rest-client-behavior/rest-client-behavior.js'; import '../../../styles/shared-styles.js'; import '../gr-change-list/gr-change-list.js';
diff --git a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view_test.html b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view_test.html index f94c896..9e9a8f2 100644 --- a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view_test.html +++ b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view_test.html
@@ -33,6 +33,7 @@ <script type="module"> import '../../../test/common-test-setup.js'; import './gr-dashboard-view.js'; +import {isHidden} from '../../../test/test-utils.js'; suite('gr-dashboard-view tests', () => { let element; let sandbox;
diff --git a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js index c076c73..fac23f2 100644 --- a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js +++ b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../../behaviors/rest-client-behavior/rest-client-behavior.js'; import '../../admin/gr-create-change-dialog/gr-create-change-dialog.js';
diff --git a/polygerrit-ui/app/elements/change/gr-change-requirements/gr-change-requirements_test.html b/polygerrit-ui/app/elements/change/gr-change-requirements/gr-change-requirements_test.html index 3a4ef25..7c8deb3 100644 --- a/polygerrit-ui/app/elements/change/gr-change-requirements/gr-change-requirements_test.html +++ b/polygerrit-ui/app/elements/change/gr-change-requirements/gr-change-requirements_test.html
@@ -33,6 +33,7 @@ <script type="module"> import '../../../test/common-test-setup.js'; import './gr-change-requirements.js'; +import {isHidden} from '../../../test/test-utils.js'; suite('gr-change-metadata tests', () => { let element;
diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js index 9656305..a8de193 100644 --- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js +++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../../behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js'; import '../../../behaviors/rest-client-behavior/rest-client-behavior.js';
diff --git a/polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.js b/polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.js index 4067d280..7868979 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-confirm-abandon-dialog/gr-confirm-abandon-dialog.js
@@ -17,7 +17,6 @@ import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js'; import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../shared/gr-dialog/gr-dialog.js'; import '../../../styles/shared-styles.js'; import {mixinBehaviors} from '@polymer/polymer/lib/legacy/class.js';
diff --git a/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-conflict-dialog/gr-confirm-cherrypick-conflict-dialog.js b/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-conflict-dialog/gr-confirm-cherrypick-conflict-dialog.js index ee302ff..480e6cf 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-conflict-dialog/gr-confirm-cherrypick-conflict-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-conflict-dialog/gr-confirm-cherrypick-conflict-dialog.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import '../../shared/gr-dialog/gr-dialog.js'; import {GestureEventListeners} from '@polymer/polymer/lib/mixins/gesture-event-listeners.js';
diff --git a/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.js b/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.js index 57ef05a..50cc7a2 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-confirm-cherrypick-dialog/gr-confirm-cherrypick-dialog.js
@@ -18,7 +18,6 @@ import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js'; import '@polymer/iron-input/iron-input.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import '../../shared/gr-autocomplete/gr-autocomplete.js'; import '../../shared/gr-dialog/gr-dialog.js';
diff --git a/polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.js b/polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.js index 9f6ce42..51ece00 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-confirm-move-dialog/gr-confirm-move-dialog.js
@@ -17,7 +17,6 @@ import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js'; import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import '../../shared/gr-autocomplete/gr-autocomplete.js'; import '../../shared/gr-dialog/gr-dialog.js';
diff --git a/polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.js b/polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.js index 4d004df..6eb4c82 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-confirm-revert-dialog/gr-confirm-revert-dialog.js
@@ -17,7 +17,6 @@ import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js'; import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../shared/gr-dialog/gr-dialog.js'; import '../../../styles/shared-styles.js'; import '../../plugins/gr-endpoint-decorator/gr-endpoint-decorator.js';
diff --git a/polygerrit-ui/app/elements/change/gr-confirm-revert-submission-dialog/gr-confirm-revert-submission-dialog.js b/polygerrit-ui/app/elements/change/gr-confirm-revert-submission-dialog/gr-confirm-revert-submission-dialog.js index 21d976f..212f909 100644 --- a/polygerrit-ui/app/elements/change/gr-confirm-revert-submission-dialog/gr-confirm-revert-submission-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-confirm-revert-submission-dialog/gr-confirm-revert-submission-dialog.js
@@ -17,7 +17,6 @@ import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js'; import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../shared/gr-dialog/gr-dialog.js'; import '../../../styles/shared-styles.js'; import '../../shared/gr-js-api-interface/gr-js-api-interface.js';
diff --git a/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js b/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js index f8faa05..fbacd02 100644 --- a/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-download-dialog/gr-download-dialog.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../../behaviors/rest-client-behavior/rest-client-behavior.js'; import '../../../styles/shared-styles.js';
diff --git a/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.js b/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.js index 459d70a..dae6313 100644 --- a/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.js +++ b/polygerrit-ui/app/elements/change/gr-file-list-header/gr-file-list-header.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../../styles/shared-styles.js'; import '../../core/gr-navigation/gr-navigation.js';
diff --git a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js index 9f94b76..430260d 100644 --- a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js +++ b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../../styles/shared-styles.js';
diff --git a/polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.js b/polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.js index cfd2588..f79dba3 100644 --- a/polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-included-in-dialog/gr-included-in-dialog.js
@@ -17,7 +17,6 @@ import '../../../scripts/bundled-polymer.js'; import '@polymer/iron-input/iron-input.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import '../../shared/gr-button/gr-button.js'; import '../../shared/gr-rest-api-interface/gr-rest-api-interface.js';
diff --git a/polygerrit-ui/app/elements/change/gr-message/gr-message.js b/polygerrit-ui/app/elements/change/gr-message/gr-message.js index 2b5f178..0c3bebb 100644 --- a/polygerrit-ui/app/elements/change/gr-message/gr-message.js +++ b/polygerrit-ui/app/elements/change/gr-message/gr-message.js
@@ -17,7 +17,6 @@ import '../../../scripts/bundled-polymer.js'; import '@polymer/iron-icon/iron-icon.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../shared/gr-account-label/gr-account-label.js'; import '../../shared/gr-account-chip/gr-account-chip.js'; import '../../shared/gr-button/gr-button.js';
diff --git a/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.js b/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.js index 3a4f331..1f3a030 100644 --- a/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.js +++ b/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../../behaviors/rest-client-behavior/rest-client-behavior.js'; import '../../core/gr-navigation/gr-navigation.js';
diff --git a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js index 3dbfd95..1224004 100644 --- a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../../behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js'; import '../../../behaviors/rest-client-behavior/rest-client-behavior.js';
diff --git a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog_test.html b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog_test.html index 50d104f..98c703f 100644 --- a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog_test.html +++ b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog_test.html
@@ -34,6 +34,7 @@ import {IronOverlayManager} from '@polymer/iron-overlay-behavior/iron-overlay-manager.js'; import '../../../test/common-test-setup.js'; import './gr-reply-dialog.js'; +import {mockPromise} from '../../../test/test-utils.js'; function cloneableResponse(status, text) { return { ok: false,
diff --git a/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js b/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js index 0fcf81d..c933c7c 100644 --- a/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js +++ b/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../shared/gr-account-chip/gr-account-chip.js'; import '../../shared/gr-button/gr-button.js'; import '../../shared/gr-rest-api-interface/gr-rest-api-interface.js';
diff --git a/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.js b/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.js index e63b69d..9171908 100644 --- a/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.js +++ b/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../shared/gr-dialog/gr-dialog.js'; import '../../shared/gr-rest-api-interface/gr-rest-api-interface.js'; import '../../shared/gr-shell-command/gr-shell-command.js';
diff --git a/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.js b/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.js index 98afa84..9842bae 100644 --- a/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.js +++ b/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.js
@@ -23,7 +23,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../gr-error-dialog/gr-error-dialog.js'; import '../gr-reporting/gr-reporting.js'; import '../../shared/gr-alert/gr-alert.js';
diff --git a/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.js b/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.js index d9b8f10..ec2dafd 100644 --- a/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.js +++ b/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js'; import '../../shared/gr-button/gr-button.js'; import '../gr-key-binding-display/gr-key-binding-display.js';
diff --git a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js index 4a3cc00..a117e77 100644 --- a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js +++ b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-admin-nav-behavior/gr-admin-nav-behavior.js'; import '../../plugins/gr-endpoint-decorator/gr-endpoint-decorator.js'; import '../../shared/gr-dropdown/gr-dropdown.js';
diff --git a/polygerrit-ui/app/elements/core/gr-router/gr-router.js b/polygerrit-ui/app/elements/core/gr-router/gr-router.js index d72f5dc..d8590c7 100644 --- a/polygerrit-ui/app/elements/core/gr-router/gr-router.js +++ b/polygerrit-ui/app/elements/core/gr-router/gr-router.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../../behaviors/gr-url-encoding-behavior/gr-url-encoding-behavior.js'; import '../gr-navigation/gr-navigation.js';
diff --git a/polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.js b/polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.js index b304b1a..f047198 100644 --- a/polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.js +++ b/polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.js
@@ -17,7 +17,6 @@ import '../../../scripts/bundled-polymer.js'; import '@polymer/iron-icon/iron-icon.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import '../../shared/gr-dialog/gr-dialog.js'; import '../../shared/gr-overlay/gr-overlay.js';
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-element.js b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-element.js index 76d3b41..68c88bc 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-element.js +++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-element.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../gr-coverage-layer/gr-coverage-layer.js'; import '../gr-diff-processor/gr-diff-processor.js'; import '../../shared/gr-hovercard/gr-hovercard.js';
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.js b/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.js index 055c148..7a1e9db 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.js +++ b/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import '../gr-selection-action-box/gr-selection-action-box.js'; import './gr-annotation.js';
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.js b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.js index 58a3b24..0f14b71 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.js +++ b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../core/gr-reporting/gr-reporting.js'; import '../../shared/gr-rest-api-interface/gr-rest-api-interface.js';
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.js b/polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.js index 98dc7e4..560cf41 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.js +++ b/polygerrit-ui/app/elements/diff/gr-diff-preferences-dialog/gr-diff-preferences-dialog.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import '../../shared/gr-button/gr-button.js'; import '../../shared/gr-diff-preferences/gr-diff-preferences.js';
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js index 09e8451..8b12ce1 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js +++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../../behaviors/gr-path-list-behavior/gr-path-list-behavior.js'; import '../../../behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js';
diff --git a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js index c86fc2e..be29a46 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js +++ b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../../styles/shared-styles.js'; import '../../shared/gr-button/gr-button.js';
diff --git a/polygerrit-ui/app/elements/diff/gr-selection-action-box/gr-selection-action-box.js b/polygerrit-ui/app/elements/diff/gr-selection-action-box/gr-selection-action-box.js index c887513..3ed84fc 100644 --- a/polygerrit-ui/app/elements/diff/gr-selection-action-box/gr-selection-action-box.js +++ b/polygerrit-ui/app/elements/diff/gr-selection-action-box/gr-selection-action-box.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js'; import '../../../styles/shared-styles.js'; import '../../shared/gr-tooltip/gr-tooltip.js';
diff --git a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js index fa700aa..9baffcc 100644 --- a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js +++ b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../../behaviors/gr-path-list-behavior/gr-path-list-behavior.js'; import '../../../behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js';
diff --git a/polygerrit-ui/app/elements/plugins/gr-event-helper/gr-event-helper.js b/polygerrit-ui/app/elements/plugins/gr-event-helper/gr-event-helper.js index 66d42d3..a48082e 100644 --- a/polygerrit-ui/app/elements/plugins/gr-event-helper/gr-event-helper.js +++ b/polygerrit-ui/app/elements/plugins/gr-event-helper/gr-event-helper.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; const $_documentContainer = document.createElement('template'); $_documentContainer.innerHTML = `<dom-module id="gr-event-helper">
diff --git a/polygerrit-ui/app/elements/settings/gr-account-info/gr-account-info.js b/polygerrit-ui/app/elements/settings/gr-account-info/gr-account-info.js index 6a3266b..7e312d3 100644 --- a/polygerrit-ui/app/elements/settings/gr-account-info/gr-account-info.js +++ b/polygerrit-ui/app/elements/settings/gr-account-info/gr-account-info.js
@@ -15,9 +15,7 @@ * limitations under the License. */ import '../../../scripts/bundled-polymer.js'; - import '@polymer/iron-input/iron-input.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../shared/gr-avatar/gr-avatar.js'; import '../../shared/gr-date-formatter/gr-date-formatter.js'; import '../../shared/gr-rest-api-interface/gr-rest-api-interface.js';
diff --git a/polygerrit-ui/app/elements/settings/gr-cla-view/gr-cla-view.js b/polygerrit-ui/app/elements/settings/gr-cla-view/gr-cla-view.js index 4a897ee..957eb48 100644 --- a/polygerrit-ui/app/elements/settings/gr-cla-view/gr-cla-view.js +++ b/polygerrit-ui/app/elements/settings/gr-cla-view/gr-cla-view.js
@@ -17,7 +17,6 @@ import '@polymer/iron-input/iron-input.js'; import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/gr-form-styles.js'; import '../../../styles/shared-styles.js'; import '../../shared/gr-button/gr-button.js';
diff --git a/polygerrit-ui/app/elements/settings/gr-registration-dialog/gr-registration-dialog.js b/polygerrit-ui/app/elements/settings/gr-registration-dialog/gr-registration-dialog.js index 665c205..1972715 100644 --- a/polygerrit-ui/app/elements/settings/gr-registration-dialog/gr-registration-dialog.js +++ b/polygerrit-ui/app/elements/settings/gr-registration-dialog/gr-registration-dialog.js
@@ -17,7 +17,6 @@ import '../../../scripts/bundled-polymer.js'; import '@polymer/iron-input/iron-input.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/gr-form-styles.js'; import '../../core/gr-navigation/gr-navigation.js'; import '../../shared/gr-button/gr-button.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-account-chip/gr-account-chip.js b/polygerrit-ui/app/elements/shared/gr-account-chip/gr-account-chip.js index 274f270..6ceee26 100644 --- a/polygerrit-ui/app/elements/shared/gr-account-chip/gr-account-chip.js +++ b/polygerrit-ui/app/elements/shared/gr-account-chip/gr-account-chip.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../gr-account-link/gr-account-link.js'; import '../gr-button/gr-button.js'; import '../gr-icons/gr-icons.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-account-entry/gr-account-entry.js b/polygerrit-ui/app/elements/shared/gr-account-entry/gr-account-entry.js index c71a8f9..c991a37 100644 --- a/polygerrit-ui/app/elements/shared/gr-account-entry/gr-account-entry.js +++ b/polygerrit-ui/app/elements/shared/gr-account-entry/gr-account-entry.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import '../gr-autocomplete/gr-autocomplete.js'; import '../gr-rest-api-interface/gr-rest-api-interface.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-account-list/gr-account-list.js b/polygerrit-ui/app/elements/shared/gr-account-list/gr-account-list.js index b51fcf4..73ccf7d 100644 --- a/polygerrit-ui/app/elements/shared/gr-account-list/gr-account-list.js +++ b/polygerrit-ui/app/elements/shared/gr-account-list/gr-account-list.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../gr-account-chip/gr-account-chip.js'; import '../gr-account-entry/gr-account-entry.js'; import '../../../styles/shared-styles.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-autocomplete-dropdown/gr-autocomplete-dropdown.js b/polygerrit-ui/app/elements/shared/gr-autocomplete-dropdown/gr-autocomplete-dropdown.js index 5503a95d..d778664 100644 --- a/polygerrit-ui/app/elements/shared/gr-autocomplete-dropdown/gr-autocomplete-dropdown.js +++ b/polygerrit-ui/app/elements/shared/gr-autocomplete-dropdown/gr-autocomplete-dropdown.js
@@ -15,8 +15,6 @@ * limitations under the License. */ import '../../../scripts/bundled-polymer.js'; - -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js'; import '@polymer/iron-dropdown/iron-dropdown.js'; import {IronFitBehavior} from '@polymer/iron-fit-behavior/iron-fit-behavior.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete.js b/polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete.js index cdec5b2..b0ec96b 100644 --- a/polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete.js +++ b/polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete.js
@@ -17,7 +17,6 @@ import '../../../scripts/bundled-polymer.js'; import '@polymer/paper-input/paper-input.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js'; import '../gr-autocomplete-dropdown/gr-autocomplete-dropdown.js'; import '../gr-cursor-manager/gr-cursor-manager.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.js b/polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.js index 95c6b31..e3e028d 100644 --- a/polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.js +++ b/polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-path-list-behavior/gr-path-list-behavior.js'; import '../../../styles/shared-styles.js'; import '../../core/gr-navigation/gr-navigation.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js index 86c7d36..09602c6 100644 --- a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js +++ b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js
@@ -18,7 +18,6 @@ import '../../../behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js'; import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import '../../core/gr-reporting/gr-reporting.js'; import '../../plugins/gr-endpoint-decorator/gr-endpoint-decorator.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-confirm-delete-comment-dialog/gr-confirm-delete-comment-dialog.js b/polygerrit-ui/app/elements/shared/gr-confirm-delete-comment-dialog/gr-confirm-delete-comment-dialog.js index 92aac6f..b0f387b 100644 --- a/polygerrit-ui/app/elements/shared/gr-confirm-delete-comment-dialog/gr-confirm-delete-comment-dialog.js +++ b/polygerrit-ui/app/elements/shared/gr-confirm-delete-comment-dialog/gr-confirm-delete-comment-dialog.js
@@ -17,7 +17,6 @@ import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js'; import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../gr-dialog/gr-dialog.js'; import '../../../styles/shared-styles.js'; import {GestureEventListeners} from '@polymer/polymer/lib/mixins/gesture-event-listeners.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog.js b/polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog.js index 4e40c88..db64661 100644 --- a/polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog.js +++ b/polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../gr-button/gr-button.js'; import '../../../styles/shared-styles.js'; import {GestureEventListeners} from '@polymer/polymer/lib/mixins/gesture-event-listeners.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog_test.html b/polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog_test.html index 8649011..919ed88 100644 --- a/polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog_test.html +++ b/polygerrit-ui/app/elements/shared/gr-dialog/gr-dialog_test.html
@@ -33,6 +33,7 @@ <script type="module"> import '../../../test/common-test-setup.js'; import './gr-dialog.js'; +import {isHidden} from '../../../test/test-utils.js'; suite('gr-dialog tests', () => { let element; let sandbox;
diff --git a/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands_test.html b/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands_test.html index f63ac0c..2543e28 100644 --- a/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands_test.html +++ b/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands_test.html
@@ -33,6 +33,7 @@ <script type="module"> import '../../../test/common-test-setup.js'; import './gr-download-commands.js'; +import {isHidden} from '../../../test/test-utils.js'; suite('gr-download-commands', () => { let element; let sandbox;
diff --git a/polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.js b/polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.js index e255f82..804eb16 100644 --- a/polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.js +++ b/polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.js
@@ -17,7 +17,6 @@ import '../../../scripts/bundled-polymer.js'; import '@polymer/iron-autogrow-textarea/iron-autogrow-textarea.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import '../gr-storage/gr-storage.js'; import '../gr-button/gr-button.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-editable-label/gr-editable-label.js b/polygerrit-ui/app/elements/shared/gr-editable-label/gr-editable-label.js index 40ed65a..3f4689e 100644 --- a/polygerrit-ui/app/elements/shared/gr-editable-label/gr-editable-label.js +++ b/polygerrit-ui/app/elements/shared/gr-editable-label/gr-editable-label.js
@@ -20,7 +20,6 @@ import {IronOverlayBehaviorImpl} from '@polymer/iron-overlay-behavior/iron-overlay-behavior.js'; import '@polymer/iron-dropdown/iron-dropdown.js'; import '@polymer/paper-input/paper-input.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import '../gr-button/gr-button.js'; import {dom} from '@polymer/polymer/lib/legacy/polymer.dom.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info_test.html b/polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info_test.html index f7e9a70..a3af731 100644 --- a/polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info_test.html +++ b/polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info_test.html
@@ -33,6 +33,7 @@ import '../../../test/common-test-setup.js'; import './gr-label-info.js'; import {dom} from '@polymer/polymer/lib/legacy/polymer.dom.js'; +import {isHidden} from '../../../test/test-utils.js'; suite('gr-account-link tests', () => { let element; let sandbox;
diff --git a/polygerrit-ui/app/elements/shared/gr-linked-chip/gr-linked-chip.js b/polygerrit-ui/app/elements/shared/gr-linked-chip/gr-linked-chip.js index 1d34f07..a4ba9e2 100644 --- a/polygerrit-ui/app/elements/shared/gr-linked-chip/gr-linked-chip.js +++ b/polygerrit-ui/app/elements/shared/gr-linked-chip/gr-linked-chip.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-tooltip-behavior/gr-tooltip-behavior.js'; import '../gr-button/gr-button.js'; import '../gr-icons/gr-icons.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-list-view/gr-list-view.js b/polygerrit-ui/app/elements/shared/gr-list-view/gr-list-view.js index 244ddb8..265ba68 100644 --- a/polygerrit-ui/app/elements/shared/gr-list-view/gr-list-view.js +++ b/polygerrit-ui/app/elements/shared/gr-list-view/gr-list-view.js
@@ -18,7 +18,6 @@ import '@polymer/iron-input/iron-input.js'; import '@polymer/iron-icon/iron-icon.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-url-encoding-behavior/gr-url-encoding-behavior.js'; import '../../../styles/shared-styles.js'; import '../gr-button/gr-button.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js b/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js index 23203e8..a5a3fb4 100644 --- a/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js +++ b/polygerrit-ui/app/elements/shared/gr-overlay/gr-overlay.js
@@ -17,7 +17,6 @@ import '../../../scripts/bundled-polymer.js'; import {IronOverlayBehaviorImpl, IronOverlayBehavior} from '@polymer/iron-overlay-behavior/iron-overlay-behavior.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../styles/shared-styles.js'; import {mixinBehaviors} from '@polymer/polymer/lib/legacy/class.js'; import {GestureEventListeners} from '@polymer/polymer/lib/mixins/gesture-event-listeners.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js index a4308c4..05291a4 100644 --- a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js +++ b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js
@@ -23,7 +23,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/gr-patch-set-behavior/gr-patch-set-behavior.js'; import '../../../behaviors/gr-path-list-behavior/gr-path-list-behavior.js'; import '../../../behaviors/rest-client-behavior/rest-client-behavior.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html index 5fd289e..77a8fe6 100644 --- a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html +++ b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html
@@ -34,6 +34,7 @@ import '../../../test/common-test-setup.js'; import '../../../scripts/util.js'; import './gr-rest-api-interface.js'; +import {mockPromise} from '../../../test/test-utils.js'; suite('gr-rest-api-interface tests', () => { let element; let sandbox;
diff --git a/polygerrit-ui/app/elements/shared/gr-select/gr-select.js b/polygerrit-ui/app/elements/shared/gr-select/gr-select.js index 10e42b4..e061e93 100644 --- a/polygerrit-ui/app/elements/shared/gr-select/gr-select.js +++ b/polygerrit-ui/app/elements/shared/gr-select/gr-select.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import {GestureEventListeners} from '@polymer/polymer/lib/mixins/gesture-event-listeners.js'; import {LegacyElementMixin} from '@polymer/polymer/lib/legacy/legacy-element-mixin.js'; import {PolymerElement} from '@polymer/polymer/polymer-element.js';
diff --git a/polygerrit-ui/app/elements/shared/gr-textarea/gr-textarea.js b/polygerrit-ui/app/elements/shared/gr-textarea/gr-textarea.js index 5cd9868..2d7acd0 100644 --- a/polygerrit-ui/app/elements/shared/gr-textarea/gr-textarea.js +++ b/polygerrit-ui/app/elements/shared/gr-textarea/gr-textarea.js
@@ -16,7 +16,6 @@ */ import '../../../scripts/bundled-polymer.js'; -import '../../../behaviors/fire-behavior/fire-behavior.js'; import '../../../behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js'; import '../gr-autocomplete-dropdown/gr-autocomplete-dropdown.js'; import '../gr-cursor-manager/gr-cursor-manager.js';
diff --git a/polygerrit-ui/app/test/common-test-setup.js b/polygerrit-ui/app/test/common-test-setup.js index ef5e015..5d9c9bb 100644 --- a/polygerrit-ui/app/test/common-test-setup.js +++ b/polygerrit-ui/app/test/common-test-setup.js
@@ -37,15 +37,6 @@ }, safeTypesBridge: Gerrit.SafeTypes.safeTypesBridge, }); -self.mockPromise = () => { - let res; - const promise = new Promise(resolve => { - res = resolve; - }); - promise.resolve = res; - return promise; -}; -self.isHidden = el => getComputedStyle(el).display === 'none'; // Default implementations of 'fixture' and 'stub' methods in // web-component-tester are incorrect. Default methods calls mocha teardown
diff --git a/polygerrit-ui/app/test/test-utils.js b/polygerrit-ui/app/test/test-utils.js new file mode 100644 index 0000000..c838fb1 --- /dev/null +++ b/polygerrit-ui/app/test/test-utils.js
@@ -0,0 +1,26 @@ +/** + * @license + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +export const mockPromise = () => { + let res; + const promise = new Promise(resolve => { + res = resolve; + }); + promise.resolve = res; + return promise; +}; +export const isHidden = el => getComputedStyle(el).display === 'none';