Google Git
Sign in
gerrit / gerrit / 4151e6f9efd71d9239bd2b65cac17790239b454c
commit4151e6f9efd71d9239bd2b65cac17790239b454c[log] [tgz]
authorLuca Milanesio <luca.milanesio@gmail.com>Wed Feb 21 21:30:47 2024 +0000
committerLuca Milanesio <luca.milanesio@gmail.com>Wed Feb 21 22:26:02 2024 +0000
treefca065c8d92b1f74f03b80f6d0f02c433549e122
parent5fb44f8c1a7a7c76a030620ff6348ee3209786d9 [diff]
Remove the useIndex option in SSH commands change id parsing

The Change I34dbf53524 introduced a specific flag for parsing
the change id in SSH commands differently for some use-cases
where there is a requirement of NOT using a Lucene index lookup.

When the flag was introduced in v2.13, Gerrit had a radically
different architecture:

- The Git repository contained only the code
- All review metadata was stored in ReviewDb
- The primary key for looking up changes was the change number
  which did not require any Lucene lookups

At that time in v2.13, the introduction of the useIndex option
allowed to fix a specific SSH command for reindexing a change
in case it was missed during the change creation of patch-set
upload.

See Issue 313935024 for more details on how a Gerrit change
may end up with a stale or completely absent indexing entry.

Starting from v2.15 and then up to v3.0, the removal of
ReviewDb code-base was implemented without paying too much
attention on the consequences on the useIndex flag which was
ported "syntatically" to the newer releases but lost completely
its effectiveness. Also, the SSH commands did not have historically
enough test coverage, exposing the risks of a regression.

On the other side, the change finder is now clever enough
to use the index or the underlying repository depending on
the format of the change id, which makes a lot more sense
than a static decision based on the useIndex flag.

Also remove the unneeded reload of the change notes found and
loaded by the changeFinder, which was inadvertently added as part
of Change Idaeeb7d82.

TODO: Remove the flag completely after this change is
merged to master. The flag is kept unused in stable
versions for not invalidating the public signature
of the methods, which may be used by other parts of
Gerrit or other plugins.

Bug: Issue 325821304
Release-Notes: Fix change id parsing in SSH commands
Change-Id: Iee2057f8978a40d37804c9198df0c1c70fdcb9eb
1 file changed
tree: fca065c8d92b1f74f03b80f6d0f02c433549e122
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.