commit 40a43748b10e4e452e7768c1d407370a6daa8c08
author Edwin Kempin <ekempin@google.com> Tue Oct 02 10:22:40 2018 +0200
committer Edwin Kempin <ekempin@google.com> Tue Oct 02 10:22:40 2018 +0200
tree 28454a04a58eb8a6d6283d9b0ddbab5b7cfebcbc
parent 732a16bcfdf1453bdcd84f827b9335a7b5fecf7e

ChangeIT: Remove redundant assertOkStatus() checks

createChange() already invokes assertOkStatus() and the caller of
createChange() don't need to do it again.

Change-Id: I8df0ed4462dfbc021deaefbb02c8ec75fc4882de
Signed-off-by: Edwin Kempin <ekempin@google.com>

javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java

diff --git a/javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java b/javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java
index 72878ee..7eaeeef 100644
--- a/javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java
+++ b/javatests/com/google/gerrit/acceptance/api/change/ChangeIT.java
@@ -650,7 +650,6 @@
   @Test
   public void reviewAndMoveToWorkInProgress() throws Exception {
     PushOneCommit.Result r = createChange();
-    r.assertOkStatus();
     assertThat(r.getChange().change().isWorkInProgress()).isFalse();
 
     ReviewInput in = ReviewInput.noScore().setWorkInProgress(true);
@@ -664,7 +663,6 @@
   @Test
   public void reviewAndSetWorkInProgressAndAddReviewerAndVote() throws Exception {
     PushOneCommit.Result r = createChange();
-    r.assertOkStatus();
     assertThat(r.getChange().change().isWorkInProgress()).isFalse();
 
     ReviewInput in =
@@ -681,7 +679,6 @@
   @Test
   public void reviewWithWorkInProgressAndReadyReturnsError() throws Exception {
     PushOneCommit.Result r = createChange();
-    r.assertOkStatus();
     ReviewInput in = ReviewInput.noScore();
     in.ready = true;
     in.workInProgress = true;
@@ -692,7 +689,6 @@
   @Test
   public void reviewWithWorkInProgressByNonOwnerReturnsError() throws Exception {
     PushOneCommit.Result r = createChange();
-    r.assertOkStatus();
     ReviewInput in = ReviewInput.noScore().setWorkInProgress(true);
     setApiUser(user);
     ReviewResult result = gApi.changes().id(r.getChangeId()).revision("current").review(in);