| commit | 4037d2f819d95ec0034086cb893bc4df1dec93d7 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Tue Oct 05 22:31:07 2021 +0200 |
| committer | Ben Rohlfs <brohlfs@google.com> | Wed Oct 06 09:55:21 2021 +0200 |
| tree | a22b94ca2530d12bc893fd5e30c6c8220fddeccf | |
| parent | d5a79c5568fecbe8ae479afd57ad1a448f64120b [diff] |
Fix a couple of layout issues caused by tooltip and gr-button migrations When gr-button was migrated to Lit it was missed that @apply does not work in static styles, so those styles should have been put into the render() method, which is a workaround that is already in place in various other Lit elements. But we want to get rid of css mixins anyway. So I took the opportunity in this change to get rid of the --gr-button mixin altogether, because it was clear that I would have to make a careful pass over the entire UI anyway with pixel by pixel comparison. So this ended up also fixing a couple of unrelated issues that were recently broken. I have basically just opened gerrit-review and compared against the Dev Helper version, and worked my way through most of the important pages and widgets until I reached nearly pixel perfect identity. gr-button being inline-block inside gr-tooltip-content is a bit unfortunate. gr-button would probably be easier to deal with, if it had display:block, but that is a change for another day. Change-Id: I7d3e57a43148000053ef63232dcb1945c1ad40be
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.