commit | 3fbb2841419324148865a1687c5613ded6ffcbfb | [log] [tgz] |
---|---|---|
author | Youssef Elghareeb <ghareeb@google.com> | Tue Sep 21 13:00:14 2021 +0200 |
committer | Youssef Elghareeb <ghareeb@google.com> | Wed Sep 22 11:55:46 2021 +0200 |
tree | 03ee56fe20ff061617b29e7fe312846ead17a9d2 | |
parent | 22d8b0549c3688544508c9d47126b81204a8caee [diff] |
Adjust SR expression with IgnoreSelfApproval labels In SubmitRequirementsAdapter we convert legacy submit records to submit requirements. We differentiate between submit records created by the default vs. custom submit rules. For submit records created by the default submit rule, we create a separate submit requirement for each label in the submit record. In this change we adjust the submittability expression if the label is setting the ignoreSelfApproval property. When this happens, we create the submittability expression as: Case MAX_WITH_BLOCK label:$label_name=MAX,user=non_uploader -label:$label_name=MIN Case MAX_NO_BLOCK label:$label_name=MAX,user=non_uploader Case ANY_WITH_BLOCK -label:$label_name=MIN i.e. we append the ",user=non_uploader" to the expression for the max vote case. We've previously implemented a non_uploader arg to the label predicate with change I3d0c7752. Change-Id: I571d19a6d15cf95b92d386f8aba1468fcbe3dbde
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.