Remove unused function from gr-main-header, gr-smart-search & gr-app-element They are unused. Change-Id: Ic4b327e17751176cd091e2b7af253cbb27f33f3c
diff --git a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.ts b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.ts index a6ee55d..21d9b97 100644 --- a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.ts +++ b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.ts
@@ -37,8 +37,7 @@ import {sharedStyles} from '../../../styles/shared-styles'; import {LitElement, PropertyValues, html, css} from 'lit'; import {customElement, property, state} from 'lit/decorators'; -import {ValueChangedEvent} from '../../../types/events'; -import {fire, fireEvent} from '../../../utils/event-util'; +import {fireEvent} from '../../../utils/event-util'; type MainHeaderLink = RequireProperties<DropdownLink, 'url' | 'name'>; @@ -103,9 +102,6 @@ ]); declare global { - interface HTMLElementEventMap { - 'search-query-changed': ValueChangedEvent; - } interface HTMLElementTagNameMap { 'gr-main-header': GrMainHeader; } @@ -383,9 +379,6 @@ label="Search for changes" .searchQuery=${this.searchQuery} .serverConfig=${this.serverConfig} - @search-query-changed=${(e: ValueChangedEvent) => { - this.handleSearchQueryBindValueChanged(e); - }} ></gr-smart-search> <gr-endpoint-decorator class="hideOnMobile" @@ -651,8 +644,4 @@ e.stopPropagation(); fireEvent(this, 'mobile-search'); } - - private handleSearchQueryBindValueChanged(e: ValueChangedEvent) { - fire(this, 'search-query-changed', {value: e.detail.value}); - } }
diff --git a/polygerrit-ui/app/elements/core/gr-smart-search/gr-smart-search.ts b/polygerrit-ui/app/elements/core/gr-smart-search/gr-smart-search.ts index 71ffe18..ed6b822 100644 --- a/polygerrit-ui/app/elements/core/gr-smart-search/gr-smart-search.ts +++ b/polygerrit-ui/app/elements/core/gr-smart-search/gr-smart-search.ts
@@ -26,7 +26,6 @@ import {getAppContext} from '../../../services/app-context'; import {LitElement, html} from 'lit'; import {customElement, property} from 'lit/decorators'; -import {fire} from '../../../utils/event-util'; const MAX_AUTOCOMPLETE_RESULTS = 10; const SELF_EXPRESSION = 'self'; @@ -73,9 +72,6 @@ @handle-search=${(e: CustomEvent<SearchBarHandleSearchDetail>) => { this.handleSearch(e); }} - @value-changed=${(e: CustomEvent) => { - this.handleSearchValueChanged(e); - }} ></gr-search-bar> `; } @@ -196,8 +192,4 @@ GerritNav.navigateToSearchQuery(input); } } - - private handleSearchValueChanged(e: CustomEvent) { - fire(this, 'search-query-changed', {value: e.detail.value}); - } }
diff --git a/polygerrit-ui/app/elements/gr-app-element.ts b/polygerrit-ui/app/elements/gr-app-element.ts index e302c8f..c509e7a 100644 --- a/polygerrit-ui/app/elements/gr-app-element.ts +++ b/polygerrit-ui/app/elements/gr-app-element.ts
@@ -65,7 +65,6 @@ import { AppElementJustRegisteredParams, AppElementParams, - AppElementSearchParam, isAppElementJustRegisteredParams, } from './gr-app-types'; import {GrMainHeader} from './core/gr-main-header/gr-main-header'; @@ -77,7 +76,6 @@ PageErrorEventDetail, RpcLogEvent, TitleChangeEventDetail, - ValueChangedEvent, } from '../types/events'; import {ViewState} from '../types/types'; import {GerritView} from '../services/router/router-model'; @@ -620,11 +618,6 @@ ? 'app-theme-dark' : 'app-theme-light'; } - - _handleSearchQueryChanged(e: ValueChangedEvent) { - if (!this.params) return; - (this.params as AppElementSearchParam).query = e.detail.value; - } } declare global {
diff --git a/polygerrit-ui/app/elements/gr-app-element_html.ts b/polygerrit-ui/app/elements/gr-app-element_html.ts index a6afb33..84e4d1a 100644 --- a/polygerrit-ui/app/elements/gr-app-element_html.ts +++ b/polygerrit-ui/app/elements/gr-app-element_html.ts
@@ -100,7 +100,6 @@ <gr-main-header id="mainHeader" search-query="[[params.query]]" - on-search-query-changed="_handleSearchQueryChanged" on-mobile-search="_mobileSearchToggle" on-show-keyboard-shortcuts="handleShowKeyboardShortcuts" mobile-search-hidden="[[!mobileSearch]]" @@ -116,7 +115,6 @@ search-query="[[params.query]]" server-config="[[_serverConfig]]" hidden="[[!mobileSearch]]" - on-search-query-changed="_handleSearchQueryChanged" > </gr-smart-search> </template>