Google Git
Sign in
gerrit / gerrit / 3ed5c01cdde0af30649dcdb98a9b24081aef5ce6
commit3ed5c01cdde0af30649dcdb98a9b24081aef5ce6[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Mon Feb 19 16:25:08 2018 +0100
committerEdwin Kempin <ekempin@google.com>Mon Feb 19 16:25:41 2018 +0100
tree7d9e53c6d3228bcc4fa0434c39466a44df8155e5
parent5a5b6ea9085a78d622a89a30a484a9d786070182 [diff]
Fix reviewer suggestion for private changes

At the moment the reviewer suggestion only suggests users that can see
the change. This is bad for private changes since only existing
reviewers can see the change. Instead of checking the visibility of the
change, check that the destination branch is visible. This is what we
have done ealier when we had draft changes. This basically reverts
change I8c223849c9, but also adds a test and fixes the comment.

Change-Id: I0245a1391b5c4a4dadb07c1ab2b71ce116adf03c
Signed-off-by: Edwin Kempin <ekempin@google.com>
2 files changed
tree: 7d9e53c6d3228bcc4fa0434c39466a44df8155e5
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. gerrit-gwtdebug/
  6. gerrit-gwtui/
  7. gerrit-gwtui-common/
  8. gerrit-plugin-gwtui/
  9. java/
  10. javatests/
  11. lib/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. resources/
  17. tools/
  18. webapp/
  19. .bazelproject
  20. .editorconfig
  21. .git-blame-ignore-revs
  22. .gitignore
  23. .gitmodules
  24. .mailmap
  25. .pydevproject
  26. BUILD
  27. COPYING
  28. INSTALL
  29. README.md
  30. SUBMITTING_PATCHES
  31. version.bzl
  32. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.