commit 3e239515f3deb1774fd288f7fdf775fe5808729c
author Kamil Musin <kamilm@google.com> Fri Feb 16 14:29:05 2024 +0100
committer Kamil Musin <kamilm@google.com> Wed Feb 28 10:29:49 2024 +0100
tree 73d93504d406a2d142b4f443ddd31f55dbcc575c
parent 9bc65ff9262ebe1fc51d18bd98c3772a703ae4f2

Remove _getChangeUrlAnd methods

This methods obscure the actual calls unnecessarily. As can be seen from
this change, making direct call to restApiHelper is almost the same
amount of code. Most of the implementation was just forwarding
parameters, which is not necessary, since we can construct the "input
object" right away.

Additionally replace send with fetch. Part of the
difference that existed in the past between send() (with parsed: false)
and fetchRawJSON() is that send() used to also check the status of the
response. That's why when we replace send() with fetch(), we set
reportServerError to true.

Moving to fetch removes semantics of send(), where it
sometimes returns parsed response and sometimes plain Response. As
evident from usage in corresponding tests, this used to lead to
confusion. Developers would expect parsed response, where in fact no
parsing is being done.

reportEndpointAsId is likely just a typo that existed previously in the
codebase. It's never read (only set), and the used in the same places
where reportEndpointAsIs makes sense. So we treat it as such.

Similarly reportUrlAsIs is likely a mistake due to this being a
parameter that is used by fetchRawJSON, but not by send(). It would
previously be dropped without being used, with this change we treat it
as reportEndpointAsIs.

The setChangeTopic and setChangeHashtags can return undefined (and could
return 'null' in the past). The return type annotation is wrong here.
There was an issue of undefined result not being processed correctly,
but that has been addressed in previous change

While converting _getDiffComments, i've noticed _getDiffCommentsFetchUrl
is unused. Likely it became unused from edits in the past. Removed.

Google-Bug-Id: b/297849592
Release-Notes: skip
Change-Id: I699a3bb79e3b1e44a70de6b770539708ff156fda