Google Git
Sign in
gerrit / gerrit / 3df9730699956d9f03d94df3a713d5057dd04eef
commit3df9730699956d9f03d94df3a713d5057dd04eef[log] [tgz]
authorKamil Musin <kamilm@google.com>Wed Oct 02 14:58:01 2024 +0200
committerKamil Musin <kamilm@google.com>Wed Oct 02 15:08:45 2024 +0200
treebb0102d8644532599f06ee53725d5c0c7ad4b162
parent39340aded6f17e8806f10c88438018d193df2858 [diff]
Improve stack information when logging network error.

If fetch call returns an error, the thrown error will only have a stack
trace starting from Scheduler, which is not useful. By re-throwing and
stitching stacks together we get better information. We have to pass the
new error into fireNetworkError and errFn, to make sure the same benefit
is observed in the event logs and for plugins.

This is not exhaustive. There are still some examples of the erors which
get thrown without extra stack information, which I couldn't figure out
how are they getting called.

This also exemplifies likely unintended behaviour when rest api is
called in gr-plugin-rest-api. Since errFn is provided the network errors
are not being reported as fireNetworkError and end up being reported as
"unhandledrejection" instead.

Release-Notes: skip
Change-Id: I650dcaaf35d0b49ff8bae4173cc5a3e78ac1d57a
2 files changed
tree: bb0102d8644532599f06ee53725d5c0c7ad4b162
  1. .github/
  2. .settings/
  3. .ts-out/
  4. antlr3/
  5. contrib/
  6. Documentation/
  7. e2e-tests/
  8. java/
  9. javatests/
  10. lib/
  11. modules/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. proto/
  17. resources/
  18. tools/
  19. webapp/
  20. polymer-bridges
  21. .bazelignore
  22. .bazelproject
  23. .bazelrc
  24. .bazelversion
  25. .editorconfig
  26. .git-blame-ignore-revs
  27. .gitignore
  28. .gitmodules
  29. .gitreview
  30. .mailmap
  31. .pydevproject
  32. .zuul.yaml
  33. BUILD
  34. COPYING
  35. INSTALL
  36. Jenkinsfile
  37. MODULE.bazel
  38. package.json
  39. README.md
  40. SUBMITTING_PATCHES
  41. version.bzl
  42. web-dev-server.config.mjs
  43. WORKSPACE
  44. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.