commit 3bb12802a7e298d820afde557dc17afc9243352b
author David Pursehouse <dpursehouse@collab.net> Mon Dec 12 09:36:50 2016 +0900
committer David Pursehouse <dpursehouse@collab.net> Mon Dec 12 09:44:09 2016 +0900
tree 70bed685a60d2802bb0f4c1ea879180e1f5631fe
parent cfb0c5b1928c6a34594015b8fe026e7052c29f01

RemoteUserUtil: Don't use default platform charset when constructing String

Reported by Error Prone 2.0.15.

Change-Id: Ia16ed7a630ed854722c819a5f2cd244cb0aff290

gerrit-httpd/src/main/java/com/google/gerrit/httpd/RemoteUserUtil.java

diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/RemoteUserUtil.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/RemoteUserUtil.java
index 479a5e5..e99838a 100644
--- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/RemoteUserUtil.java
+++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/RemoteUserUtil.java
@@ -16,6 +16,7 @@
 
 import static com.google.common.base.Strings.emptyToNull;
 import static com.google.common.net.HttpHeaders.AUTHORIZATION;
+import static java.nio.charset.StandardCharsets.UTF_8;
 
 import org.eclipse.jgit.util.Base64;
 
@@ -72,7 +73,7 @@
 
     } else if (auth.startsWith("Basic ")) {
       auth = auth.substring("Basic ".length());
-      auth = new String(Base64.decode(auth));
+      auth = new String(Base64.decode(auth), UTF_8);
       final int c = auth.indexOf(':');
       return c > 0 ? auth.substring(0, c) : null;