| commit | 3b5fb8113fbc429f233779eb9e6fe18c5849d659 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Tue Jan 09 15:21:06 2018 -0500 |
| committer | Dave Borowitz <dborowitz@google.com> | Tue Jan 09 15:21:06 2018 -0500 |
| tree | 9c96a11bc36c4ba0cea81dc47ed744fdf4cf2823 | |
| parent | e160dfed94b57deb06b80b7d4b92222504963747 [diff] |
Remove DraftHandling.DELETE Using this as the default is more dangerous than useful: if a caller forgets to populate the `drafts` field in ReviewInput, then drafts are unceremoniously deleted. A much safer default is KEEP; this also comes closest to preserving the old behavior, which also does not publish any drafts. We don't know of anybody relying on DELETE as the default, but just in case, this is probably the safest new default. An alternative proposal[1] would phase out the old default more slowly. However, given that the community couldn't come up with any use cases for the old default[2], that much caution is unnecessary, especially when compared with the real risk of data loss in the current state. [1] https://gerrit-review.googlesource.com/c/gerrit/+/140055 [2] https://groups.google.com/d/topic/repo-discuss/caWj8VqUVDY/discussion Change-Id: Idd8cdd6e93c17f296dc62c400980323f0167ae9f
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.