Revert "Buck: Preserve SNAPSHOT suffix in Maven artifact names"

This prevents gwtorm snapshots from being downloaded from the
Gerrit maven repository.

This reverts commit 731967591ef98ab3c94691ba9dc0f217630dda76.

Change-Id: I17aad32606d4afb1c0654ffca0747f660c148520
diff --git a/lib/maven.defs b/lib/maven.defs
index b874d8e..6eb2b0a 100644
--- a/lib/maven.defs
+++ b/lib/maven.defs
@@ -48,11 +48,17 @@
     raise NameError('expected id="groupId:artifactId:version"')
   group, artifact, version = parts
 
-  jar = path.join(name, artifact.lower() + '-' + version)
+  if 'SNAPSHOT' in version:
+    file_version = version.replace('-SNAPSHOT', '')
+    version = version.split('-SNAPSHOT')[0] + '-SNAPSHOT'
+  else:
+    file_version = version
+
+  jar = path.join(name, artifact.lower() + '-' + file_version)
   url = '/'.join([
     repository,
     group.replace('.', '/'), artifact, version,
-    artifact + '-' + version])
+    artifact + '-' + file_version])
 
   binjar = jar + '.jar'
   binurl = url + '.jar'