commit | a1948ebf970ef0accfbd390627ace5704703d61d | [log] [tgz] |
---|---|---|
author | Fabio Ponciroli <ponch78@gmail.com> | Wed Jan 03 20:16:55 2024 +0100 |
committer | Fabio Ponciroli <ponch78@gmail.com> | Thu Jan 04 17:19:47 2024 +0100 |
tree | 42dabed9faa468f0a5baf257776237d02249b0a0 | |
parent | c9d153f3830ab5864d71f311c0d5f99f02d0a624 [diff] |
Test comment linking of imported changes When importing changes from another server, the user in the comment might not match the one in the change message. The same user on different Gerrit instances might have different account Ids. To consolidate it, an entry in the external-ids account reverse lookup need to be added [1]. The update of external-ids is a "manual" process, and until it is done, any reference to a "not identifiable" user will default to a placeholder one. If this consolidation hasn't happened yet, when rendering the change detail page, links between comments and change messages can be broken. This manifests with comments not displayed at all in change log entries. It will happen for the broken change and all the ones following it chronologically. This wasn't considered as part of Ia478b891 and the exit conditions. This test demonstrates the breaking scenario. [1]: https://www.gerritcodereview.com/3.7.html#import-projects-changes-from-other-gerrit-servers Bug: Issue 318079520 Release-Notes: skip Change-Id: I72e3af09abd63b0c758744d69bab83b8448b2c7f
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.