Prefer Apache Commons DBCP over c3p0 connection pool
I have simply had too much trouble on my production servers with
the c3p0 pool. When the available connections are exhausted the
c3p0 pool just locks up and stops handing out connections, and user
threads wait indefinately. That causes threads to back up in the
JVM until the JVM crashes due to running out of thread stack space.
DBCP has proven to be more reliable on at least one higher-load
server, so I'm changing the recommended default in Gerrit to DBCP.
The wait time of 60 seconds ensures threads don't block indefinately,
but instead allows them to abort with an exception indicating the
database is not available.
Change-Id: I6c94d54b1f09c895c7404ef477f3972ba09da8c2
Signed-off-by: Shawn O. Pearce <sop@google.com>
2 files changed
