Link directly to reverted change in status chip
Previously, the "Revert submitted" link on the change status chip used a
search query (e.g., `/q/12345`) to navigate to the reverted change. This
was problematic because the search query could inadvertently match
commit SHAs that started with the same number, leading to an ambiguous
search results page instead of opening the change directly.
This change updates the link generation to use `createChangeUrl`
instead. By providing the change number and project name, the link now
navigates directly to the specific change page, bypassing the search
interface and ensuring the correct destination is reached.
Google-Bug-Id: b/468255948
Release-Notes: skip
Change-Id: I6d0a37d708c97e2a0eb8dbf05b0a2b49690c80d2
diff --git a/polygerrit-ui/app/elements/shared/gr-change-status/gr-change-status.ts b/polygerrit-ui/app/elements/shared/gr-change-status/gr-change-status.ts
index 9c694bf..c8524a6 100644
--- a/polygerrit-ui/app/elements/shared/gr-change-status/gr-change-status.ts
+++ b/polygerrit-ui/app/elements/shared/gr-change-status/gr-change-status.ts
@@ -10,7 +10,7 @@
import {sharedStyles} from '../../../styles/shared-styles';
import {css, html, LitElement, PropertyValues} from 'lit';
import {customElement, property, state} from 'lit/decorators.js';
-import {createSearchUrl} from '../../../models/views/search';
+import {createChangeUrl} from '../../../models/views/change';
export const WIP_TOOLTIP =
"This change isn't ready to be reviewed or submitted. " +
@@ -189,7 +189,10 @@
// private but used in test
getStatusLink(): string {
if (this.revertedChange) {
- return createSearchUrl({query: `${this.revertedChange._number}`});
+ return createChangeUrl({
+ changeNum: this.revertedChange._number,
+ repo: this.revertedChange.project,
+ });
}
if (
this.status === ChangeStates.MERGE_CONFLICT &&
diff --git a/polygerrit-ui/app/elements/shared/gr-change-status/gr-change-status_test.ts b/polygerrit-ui/app/elements/shared/gr-change-status/gr-change-status_test.ts
index 4106672..686e647 100644
--- a/polygerrit-ui/app/elements/shared/gr-change-status/gr-change-status_test.ts
+++ b/polygerrit-ui/app/elements/shared/gr-change-status/gr-change-status_test.ts
@@ -135,7 +135,10 @@
element.resolveWeblinks = [];
element.status = status;
assert.isTrue(element.hasStatusLink());
- assert.equal(element.getStatusLink(), `/q/${TEST_NUMERIC_CHANGE_ID}`);
+ assert.equal(
+ element.getStatusLink(),
+ `/c/${revertedChange.project}/+/${TEST_NUMERIC_CHANGE_ID}`
+ );
});
test('private', async () => {
