| commit | 388bc904c08971961ec1bf831280be97de2e5abf | [log] [tgz] |
|---|---|---|
| author | Milutin Kristofic <milutin@google.com> | Wed Aug 07 11:07:20 2019 +0200 |
| committer | Milutin Kristofic <milutin@google.com> | Wed Aug 07 12:10:03 2019 +0200 |
| tree | d9f490505f4bcaf2f1b4acf9ac2ce8e912596cc9 | |
| parent | 4f06d7455821e87e216111b7424a25e4c4a206df [diff] |
Login is false when network fails getLoggedIn catches errors and it returns false on being logged in. Gr-router preheat getLoggedIn and we want to return result in any case Change-Id: I8454f89bced801da7e9a0f287c8fb6e2c5446dc5
diff --git a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js index c3fc3a2..322cf5a 100644 --- a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js +++ b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js
@@ -1095,6 +1095,8 @@ getLoggedIn() { return this.getAccount().then(account => { return account != null; + }).catch(() => { + return false; }); },
diff --git a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html index 4c35151..748cb83 100644 --- a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html +++ b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html
@@ -494,6 +494,15 @@ }); }); + test('getLoggedIn returns false when network/auth failure', done => { + window.fetch.returns( + Promise.reject(new Error('Failed to fetch'))); + element.getLoggedIn().then(isLoggedIn => { + assert.isFalse(isLoggedIn); + done(); + }); + }); + test('checkCredentials', done => { const responses = [ {