Google Git
Sign in
gerrit / gerrit / 34216181660d2ac56a7eb5e8d7159e252182497b
commit34216181660d2ac56a7eb5e8d7159e252182497b[log] [tgz]
authorGal Paikin <paiking@google.com>Tue Jun 09 10:52:59 2020 +0300
committerGal Paikin <paiking@google.com>Wed Jun 24 12:46:05 2020 +0300
tree26e8a06c6e30614d226dcc7826712064c7768d79
parent916d9092212f85bdf0890aa27285fde2a44c6c3d [diff]
Differentiate RobotComment and HumanComment

Currently, RobotComment extends Comment, and Comment essentially
could only be written by a human.
There are some fields that RobotComment has, but HumanComment doesn't
have, which are defined inside RobotComment. However, there are also
fields that HumanComment has, but RobotComment doesn't (unresolved).

Currently, HumanComment is actually empty, since we didn't migrate the
"unresolved" flag yet.

As a follow-up change, we will also remove the "unresolved" flag from
Comment, and migrate it into HumanComment. RobotComments can't get
resolved, so it's unnecessary to have this flag there.

Also, as a follow-up change we will remove "Status" enum from Comment,
and migrate it into HumanComment. This field also applies only to
HumanComments since RobotComments can't be "drafts".

The suggested new structure is as follows:
1. Comment is the class that holds the fields that both HumanComment and
RobotComment have.
2. RobotComment is the existing class, and will not have any changes.
3. HumanComment is the new class that extends Comment. Currently,
HumanComment will be empty.

Most changes in this change are straightforwardly renaming "Comment" to
"HumanComment". However, some places used "Comment" as something that
could be both RobotComment and HumanComment, and then "Comment" remains.

This change only focuses on the storage side of Comments. The follow-up
change will change CommentInfo, CommentInput, RobotCommentInput and
RobotCommentInfo.

Backwards compatibility is not 100% ensured in this case, since some
plugins still use the previous Comment as HumanComment. For that case,
I created the following changes: I21f3119b1, Ida9fa5149.
The plugins that use "Comment" this way were found here:
https://cs.bazel.build/search?q=entities.Comment+r%3Agerrit+r%3Aplugin

Change-Id: I45924cb3f89dcc0d33814aab30fb7fee0c7c26f5
63 files changed
tree: 26e8a06c6e30614d226dcc7826712064c7768d79
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. e2e-tests/
  6. java/
  7. javatests/
  8. lib/
  9. modules/
  10. plugins/
  11. polygerrit-ui/
  12. prolog/
  13. prologtests/
  14. proto/
  15. resources/
  16. tools/
  17. webapp/
  18. polymer-bridges
  19. .bazelignore
  20. .bazelproject
  21. .bazelrc
  22. .bazelversion
  23. .editorconfig
  24. .git-blame-ignore-revs
  25. .gitignore
  26. .gitmodules
  27. .gitreview
  28. .mailmap
  29. .pydevproject
  30. .zuul.yaml
  31. BUILD
  32. COPYING
  33. INSTALL
  34. Jenkinsfile
  35. package.json
  36. README.md
  37. SUBMITTING_PATCHES
  38. version.bzl
  39. WORKSPACE
  40. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.