commit 31674018f3d2a691efecabd5151f57d58db2bbb9
author David Ostrovsky <david@ostrovsky.org> Fri Dec 07 22:47:31 2018 +0100
committer Dave Borowitz <dborowitz@google.com> Fri Dec 07 13:56:50 2018 -0800
tree 8d489773ce5e72b2a30c69b47980bef8e8a6e251
parent caed42cdd0250c6b22c337968e47595cc45bcba3

AbstractDisabledAccess: Remove unused wrapper attribute

Change-Id: I3ec203519a6e906fd2120c38e36241daead57c92

java/com/google/gerrit/server/schema/AbstractDisabledAccess.java

diff --git a/java/com/google/gerrit/server/schema/AbstractDisabledAccess.java b/java/com/google/gerrit/server/schema/AbstractDisabledAccess.java
index 7ebc741..72cd706 100644
--- a/java/com/google/gerrit/server/schema/AbstractDisabledAccess.java
+++ b/java/com/google/gerrit/server/schema/AbstractDisabledAccess.java
@@ -37,12 +37,6 @@
     return Futures.immediateCheckedFuture(null);
   }
 
-  private final NoChangesReviewDb wrapper;
-
-  AbstractDisabledAccess(NoChangesReviewDb wrapper) {
-    this.wrapper = wrapper;
-  }
-
   @Override
   public final int getRelationID() {
     throw new UnsupportedOperationException(GONE);

java/com/google/gerrit/server/schema/NoChangesReviewDb.java

diff --git a/java/com/google/gerrit/server/schema/NoChangesReviewDb.java b/java/com/google/gerrit/server/schema/NoChangesReviewDb.java
index 083ecd1..80a18b9 100644
--- a/java/com/google/gerrit/server/schema/NoChangesReviewDb.java
+++ b/java/com/google/gerrit/server/schema/NoChangesReviewDb.java
@@ -30,7 +30,6 @@
 import com.google.gerrit.reviewdb.server.SchemaVersionAccess;
 import com.google.gwtorm.server.Access;
 import com.google.gwtorm.server.ListResultSet;
-import com.google.gwtorm.server.OrmException;
 import com.google.gwtorm.server.ResultSet;
 import com.google.gwtorm.server.StatementExecutor;
 
@@ -53,11 +52,11 @@
   private final PatchLineCommentAccess patchComments;
 
   NoChangesReviewDb() {
-    changes = new Changes(this);
-    patchSetApprovals = new PatchSetApprovals(this);
-    changeMessages = new ChangeMessages(this);
-    patchSets = new PatchSets(this);
-    patchComments = new PatchLineComments(this);
+    changes = new Changes();
+    patchSetApprovals = new PatchSetApprovals();
+    changeMessages = new ChangeMessages();
+    patchSets = new PatchSets();
+    patchComments = new PatchLineComments();
   }
 
   @Override
@@ -121,10 +120,6 @@
 
   private static class Changes extends AbstractDisabledAccess<Change, Change.Id>
       implements ChangeAccess {
-    private Changes(NoChangesReviewDb wrapper) {
-      super(wrapper);
-    }
-
     @Override
     public ResultSet<Change> all() {
       return empty();
@@ -134,32 +129,24 @@
   private static class ChangeMessages
       extends AbstractDisabledAccess<ChangeMessage, ChangeMessage.Key>
       implements ChangeMessageAccess {
-    private ChangeMessages(NoChangesReviewDb wrapper) {
-      super(wrapper);
-    }
-
     @Override
-    public ResultSet<ChangeMessage> byChange(Change.Id id) throws OrmException {
+    public ResultSet<ChangeMessage> byChange(Change.Id id) {
       return empty();
     }
 
     @Override
-    public ResultSet<ChangeMessage> byPatchSet(PatchSet.Id id) throws OrmException {
+    public ResultSet<ChangeMessage> byPatchSet(PatchSet.Id id) {
       return empty();
     }
 
     @Override
-    public ResultSet<ChangeMessage> all() throws OrmException {
+    public ResultSet<ChangeMessage> all() {
       return empty();
     }
   }
 
   private static class PatchSets extends AbstractDisabledAccess<PatchSet, PatchSet.Id>
       implements PatchSetAccess {
-    private PatchSets(NoChangesReviewDb wrapper) {
-      super(wrapper);
-    }
-
     @Override
     public ResultSet<PatchSet> byChange(Change.Id id) {
       return empty();
@@ -174,10 +161,6 @@
   private static class PatchSetApprovals
       extends AbstractDisabledAccess<PatchSetApproval, PatchSetApproval.Key>
       implements PatchSetApprovalAccess {
-    private PatchSetApprovals(NoChangesReviewDb wrapper) {
-      super(wrapper);
-    }
-
     @Override
     public ResultSet<PatchSetApproval> byChange(Change.Id id) {
       return empty();
@@ -202,10 +185,6 @@
   private static class PatchLineComments
       extends AbstractDisabledAccess<PatchLineComment, PatchLineComment.Key>
       implements PatchLineCommentAccess {
-    private PatchLineComments(NoChangesReviewDb wrapper) {
-      super(wrapper);
-    }
-
     @Override
     public ResultSet<PatchLineComment> byChange(Change.Id id) {
       return empty();