commit 315d4a83b22977e6bb824eed940b2ed7136aa0f2
author Edwin Kempin <ekempin@google.com> Fri Sep 15 13:15:34 2023 +0000
committer Wendy Wen Wang <wendy.wang10@sap.com> Fri Sep 15 13:36:04 2023 +0000
tree 0ccfea329691606b9ef45028975d8e5825a15f92
parent 2563e0b161880a768de12910a6cd3b71e9314e84

CloudSpannerAccountPatchReviewStore#convertError: Fix endless recursion

If the given SQLException cannot be mapped to DuplicateKeyException the
method recursively invoked itself resulting in an endless loop.

Release-Notes: skip
Change-Id: Ie4c1afb2b543cf0437e1fb85271e5844704f1070
Signed-off-by: Edwin Kempin <ekempin@google.com>
(cherry picked from commit a590f25374f3fb2b9e20b2663be6b5c48d578f7f)

java/com/google/gerrit/server/schema/CloudSpannerAccountPatchReviewStore.java

diff --git a/java/com/google/gerrit/server/schema/CloudSpannerAccountPatchReviewStore.java b/java/com/google/gerrit/server/schema/CloudSpannerAccountPatchReviewStore.java
index 3c88e3a..d993c4a 100644
--- a/java/com/google/gerrit/server/schema/CloudSpannerAccountPatchReviewStore.java
+++ b/java/com/google/gerrit/server/schema/CloudSpannerAccountPatchReviewStore.java
@@ -49,7 +49,6 @@
         return new DuplicateKeyException("ACCOUNT_PATCH_REVIEWS", err);
 
       default:
-        convertError(op, err);
         return new StorageException(op + " failure on ACCOUNT_PATCH_REVIEWS", err);
     }
   }