| commit | 30325c2b7aaf95f12b2d6112c6981c6276638340 | [log] [tgz] |
|---|---|---|
| author | Changcheng Xiao <xchangcheng@google.com> | Thu Mar 29 13:33:13 2018 +0200 |
| committer | Changcheng Xiao <xchangcheng@google.com> | Wed May 02 09:46:25 2018 +0200 |
| tree | e490f2306ce494c0410f09a8f9449b5fb1f32848 | |
| parent | d4d83c50f1201e58311cb40092aedc8e77407a40 [diff] |
Move the 'isPatchSetLocked' check out from the ChangeControl PermissionBackend is supposed to only perform permission related checks. The 'isPatchSetLocked' check is a patch set status check to decide whether a change is able to be rebased, abandoned, etc. It's not permission related and thus should be moved out from the ChangeControl. This commit moves the 'isPatchSetLocked' method to the PatchSetUtil class which looks like the best destination of this method. After this move, each time the caller tries to check the REBASE/ABANDON/RESTORE/ADD_PATCH_SET permission, it must verify the patch set of the change is not locked. If it's locked the request should be rejected directly without checking any further permissions. This commit makes sure every existing usage has done this prerequest check in advance. Change-Id: Ic5cef11228f152cb3f51eea0a7aee100332f263a
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.