commit | 2f7e0e4b07de7bd6a46f477e069e39bb049e0d2e | [log] [tgz] |
---|---|---|
author | Patrick Hiesel <hiesel@google.com> | Mon Oct 08 15:10:00 2018 +0200 |
committer | Patrick Hiesel <hiesel@google.com> | Wed Oct 17 16:49:02 2018 +0200 |
tree | 44f6fb59d415594c4b99805923009b344fbb415d | |
parent | 58cca3763442c6e4e973bd7a2f185ed9e80773f6 [diff] |
Disallow submitting of changes that depend on non-visible private changes This is a follow up on the revert of Ia57ed8ef4 that takes a slightly different approach. Instead of letting the index filter by visiblity (which is doing a post-filter using ChangeIsVisibleToPredicate) we retrieve all results and apply the predicate by hand. This way, we can add non-visible changes to the set of non-visible changes and block the submit. We could alternatively also use the PermissionBackend to filter the list, but that would require us to do exactly the same as what is done in ChangeIsVisibleToPredicate. Since the predicate is public and we apply it to a list we directly obtained from the index, reusing it seems OK. Change-Id: I102ad38e3544d92448300a2a204fe657b344faa6
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.