commit 2f463649508e786a86451caa72501d0f165b3999
author Hugo Arès <hugo.ares@ericsson.com> Wed Aug 17 14:41:42 2016 -0400
committer David Pursehouse <dpursehouse@collab.net> Thu Aug 18 02:45:45 2016 +0000
tree 7f14d4ec4c388e18da2def8f2d0ae663e083afb0
parent 9a662a0755547a6d115922912930a0ef8d063e88

Schedule log file compression at 11:00pm

Log file compression was happening every 24 hours but the exact time was
depending on when Gerrit was started. First execution was 1 hour after
Gerrit is started and then every 24 hours. This behavior could confuse
Gerrit administrators because it looks like log compression is random.

Since logs are rotated upon first logging event after midnight,
compressing logs at 11:00pm should give enough time for all logs to
rotate, worst case they will be compressed the day after.

Change-Id: I81d4df8c57996a483378f6107cd6db561fa0d670

gerrit-pgm/BUCK

diff --git a/gerrit-pgm/BUCK b/gerrit-pgm/BUCK
index e62079f..4be941c 100644
--- a/gerrit-pgm/BUCK
+++ b/gerrit-pgm/BUCK
@@ -16,6 +16,7 @@
   '//lib/guice:guice-assistedinject',
   '//lib/guice:guice-servlet',
   '//lib/jgit/org.eclipse.jgit:jgit',
+  '//lib/joda:joda-time',
   '//lib/log:api',
   '//lib/log:log4j',
 ]

gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/LogFileCompressor.java

diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/LogFileCompressor.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/LogFileCompressor.java
index 6db7e87..262997b 100644
--- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/LogFileCompressor.java
+++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/util/LogFileCompressor.java
@@ -15,6 +15,7 @@
 package com.google.gerrit.pgm.util;
 
 import static java.util.concurrent.TimeUnit.HOURS;
+import static java.util.concurrent.TimeUnit.MILLISECONDS;
 
 import com.google.common.io.ByteStreams;
 import com.google.gerrit.extensions.events.LifecycleListener;
@@ -23,6 +24,8 @@
 import com.google.gerrit.server.git.WorkQueue;
 import com.google.inject.Inject;
 
+import org.joda.time.DateTime;
+import org.joda.time.Duration;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -59,7 +62,14 @@
 
     @Override
     public void start() {
-      queue.getDefaultQueue().scheduleAtFixedRate(compressor, 1, 24, HOURS);
+      //compress log once and then schedule compression every day at 11:00pm
+      queue.getDefaultQueue().execute(compressor);
+      DateTime now = DateTime.now();
+      long milliSecondsUntil11am =
+          new Duration(now, now.withTimeAtStartOfDay().plusHours(23))
+              .getMillis();
+      queue.getDefaultQueue().scheduleAtFixedRate(compressor,
+          milliSecondsUntil11am, HOURS.toMillis(24), MILLISECONDS);
     }
 
     @Override