commit 2ea70d1a8ce20e4b86b0182c880521ed1af07438
author Wyatt Allen <wyatta@google.com> Fri Apr 07 15:41:42 2017 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Fri Apr 07 15:41:42 2017 +0000
tree b4e7cca481c9bd89dacb4968d45be71628984c75
parent 9a803927074b9b2399c38dfdf0b00602023dc41c
parent 03049078177a621e3967b07b779396a77aa59471

Merge "Fix dropdown tap on touch device"

polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js

diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
index d9561cb..b795d64 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
+++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
@@ -580,7 +580,11 @@
     },
 
     _handleFileTap: function(e) {
-      this.$.dropdown.close();
+      // async is needed so that that the click event is fired before the
+      // dropdown closes (This was a bug for touch devices).
+      this.async(function() {
+        this.$.dropdown.close();
+      }, 1);
     },
 
     _handleMobileSelectChange: function(e) {

polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js

diff --git a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js
index 6ab1301..9b87f03 100644
--- a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js
+++ b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js
@@ -63,7 +63,11 @@
     },
 
     _handleDropdownTap: function(e) {
-      this.$.dropdown.close();
+      // async is needed so that that the click event is fired before the
+      // dropdown closes (This was a bug for touch devices).
+      this.async(function() {
+        this.$.dropdown.close();
+      }, 1);
     },
 
     _showDropdownTapHandler: function(e) {