PostReview: Do not fail with ISE if reviewer in ReviewerInput is missing Before this change, calling PostReview failed with '500 Internal Server Error' when the user provided a ReviewerInput that didn't have the 'reviewer' field set. If bad user input is provided we usually reject the request with '400 Bad Request' but since PostReview can batch multiple operations (e.g. multiple reviewer updates) it always returns '200 OK' and errors are provided in the returned ReviewResult. Hence if a ReviewerInput without a reviewer is specified return a proper error message in the ReviewResult. Adding reviewers is also possible with PostReviewers. While we are at this update PostReviewers to make the error handling for missing reviewer user identifiers consistent and improve the error message: * Before this change, PostReviewers rejected a null reviewer with a '400 Bad Request' reposnse but an empty reviewer resulted in a '200 OK' response with an error in the returned ReviewerResult. Now in both cases we return a '200 OK' response with an error in the returned ReviewerResult. * The error message for when an empty reviewer is provided is improved from saying " is not a valid user identifier" to saying "reviewer user identifier is required". Bug: Google b/326096919 Release-Notes: Fixed internal server error when posting a review with a ReviewerInput that didn't set the 'reviewer' field. Change-Id: I0b523c58a97a7c48d5d7610ea24d167a5f8fa0b9 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.