MergeSuperSet: Handle changes that exist in index but not in NoteDb gracefully If a system has multiple primary nodes it can happen that the index returns changes for a topic that don't exist in NoteDb yet which then causes the SubmittedTogether REST endpoint to fail on permission checks: 1. Change 1 with topic foo is created and replicated to all nodes. 2. Change 2 with topic foo is created on node X, the index data is replicated to all nodes, but the replication for the Git data is still pending. 3. The SubmittedTogether REST endpoint is invoked for change 1 on node Y. A query to the change index is executed to find all changes that have the same topic as change 1. The index query by topic returns change 1 and change 2 (because the index data is already replicated). Checking read permissions for change 2 fails because loading the change notes from Git fails (because the Git data was not replicated yet). Instead of failing we now create the change notes from the index data so that the read permission check can be performed successfully. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I4c3284877483b8248f8c2a1f7f529d93f41dbbb8
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.