|author||Ben Rohlfs <firstname.lastname@example.org>||Mon Jan 23 17:11:38 2023 +0100|
|committer||Ben Rohlfs <email@example.com>||Tue Jan 24 17:54:18 2023 +0100|
Extract route handling into view model This is a refactoring for just 1 of ~50 routes. Once this is reviewed and submitted we will follow up with the 49 routes. The core of all route handlers is to convert a URL into a view model state. We think that it is vital to have the code for converting state into URL and back in the same file. We already have the create...Url() functions in view model classes. We would also like to have urlToState() functions in the same file. It is also beneficial to have the patterns for matching a URL and the function for converting the URL into a state object very close to each other. Let's create the notion of a `Route` for that. This is just `pattern` and `createState()` in one object. Most of the current handlers just use the `params` and the `querystring` for creating a view state, and then they call `this.setState()` and `viewModel.setState()`. Let's create a new method `mapRouteState()` that is similar to what `mapRoute()` does, but caters for the newly introduced concepts above. There are tons of things that could be further refactored in the router, but we are trying to be focused with this change, and only do one thing. We are happy to add further TODOs and comments though, if reviewers have ideas or questions. One of the goals of this change is also to address the fragile handling of repo routes. It will be very beneficial for that effort to have all the handlers and tests in one place. Release-Notes: skip Change-Id: I537733c099660470019840ab4614a751dd5ec1d9
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.