| commit | 05750b9c46997f2bbb63fc877ca12f23fe70f61d | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Fri Oct 29 08:23:08 2021 +0200 |
| committer | Ben Rohlfs <brohlfs@google.com> | Tue Nov 30 13:01:21 2021 +0100 |
| tree | 99425241ec8f36d542b49e921ec88bee9edfad14 | |
| parent | 95509eda120edf759eedf6977af4e4fd48126ce1 [diff] |
Completely rewrite commenting components and data model This XL change consists of many things. Firstly, it converts the three central commenting components from PolymerElement to LitElement: <gr-comment>, <gr-comment-thread>, <gr-thread-list>. As usual, that also means that the components are partially listening to application wide state through subscriptions instead of getting all the data from their parents. The comment threads are still passed down from parent components, but it is expected that thread lists and thread objects are immutable and always change as a whole. The advantage is that the components don't have to watch sub-properties. And Lit handles component re-use and change detection very well, so there is no performance issue and also no problem of undesired user-visible re-rendering. REST API calls around retrieving, modifying and discarding of comments were moved strictly to the comments-service. The components don't make backend calls themselves. The data model was changed such that drafts are now cleanly split up into DraftInfo for saved drafts and UnsavedInfo for unsaved drafts. Saved drafts are managed by the comments service and model, and changes to them are propagated throughout the app. Unsaved drafts are just local UI state of the comment components. Storing temporary unsaved comment information in localStorage is removed in this change. The goal is to replace this by auto-saving comments, so users can still not lose a substantial amount of data. Ideally auto- saving will be implemented in a child change and submitted together. Google-Bug-Id: b/206014286 Change-Id: Ia6d3324516ef5db32a7562852319b645a5bb0f6e
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.