commit 2cd5b7470897796b91488b57333d542a325a8276
author David Ostrovsky <david@ostrovsky.org> Sun Oct 06 00:13:58 2019 +0200
committer David Pursehouse <dpursehouse@collab.net> Mon Feb 17 08:20:25 2020 +0900
tree 537936a57c043279b2eac121024d21d626ba869c
parent 17ef12713b76b75a31fdf03b80bbd60f21ee5d0b

Bazel: Remove superfluous dependencies flagged by unused_deps

Bazel buildtools project includes in addition to buildifier also unused
deps and buildozer utilities, that detect unused dependencies and fix
them by applying the removal to the build files. This change is created
by installing unused_deps from buildtools@HEAD and running:

  $ unused_deps //...

and applying the suggested modifications.

One side effect of this clean up, is that some plugins might need to be
adapted. Particularly, j.c.g.g.server.audit:audit rule excessively added
unused dependencies, among other lucene, and the audit rule is included
in j.c.g.g.testing:gerrit-test-util rules and thus inherited by the core
and plugins testing code. The correct way to do it, is to add lucene as
runtime dependency instead.

Another side effect is that //prolog:gerrit-prolog-common is now removed
from j.c.g.g.httpd.init:init rule (as it is unused there). Given that
init rule is a root for gerrit.war gathering machinery, the prolog
predicates would be missing in the final build artifact. To rectify, add
prolog predicates in addition to the init rule to the gerrit.war
gathering machinery.

Change-Id: Ib3e6c218ffc6a85f31e8a1192cdd60c759cbd68e