commit 2c76a76449b94574040c5fc6c53cd4684d1717f5
author Shawn Pearce <sop@google.com> Fri Aug 11 22:41:21 2017 -0700
committer Shawn Pearce <sop@google.com> Fri Aug 11 23:23:19 2017 -0700
tree 7de7253bb0ab1787688b4b2aef8d35d4b4ac84f4
parent 5d89130d92e84c55879fc89ca5f9e232c3be71c6

CherryPick: use BooleanCondition for visible

Change-Id: I0d640e5e64d72e18bb49b15e1036f0094d80f1f5

gerrit-server/src/main/java/com/google/gerrit/server/change/CherryPick.java

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/CherryPick.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/CherryPick.java
index 993148e..930cb8b 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/change/CherryPick.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/CherryPick.java
@@ -14,6 +14,8 @@
 
 package com.google.gerrit.server.change;
 
+import static com.google.gerrit.extensions.conditions.BooleanCondition.and;
+
 import com.google.gerrit.extensions.api.changes.CherryPickInput;
 import com.google.gerrit.extensions.common.ChangeInfo;
 import com.google.gerrit.extensions.restapi.BadRequestException;
@@ -106,10 +108,11 @@
         .setLabel("Cherry Pick")
         .setTitle("Cherry pick change to a different branch")
         .setVisible(
-            rsrc.isCurrent()
-                && permissionBackend
+            and(
+                rsrc.isCurrent(),
+                permissionBackend
                     .user(user)
                     .project(rsrc.getProject())
-                    .testOrFalse(ProjectPermission.CREATE_CHANGE));
+                    .testCond(ProjectPermission.CREATE_CHANGE)));
   }
 }