Merge "Convert gr-kyeboard-shortcuts-dialog_test to typescript"
diff --git a/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog_test.js b/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog_test.js
deleted file mode 100644
index f76041e..0000000
--- a/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog_test.js
+++ /dev/null
@@ -1,166 +0,0 @@
-/**
- * @license
- * Copyright (C) 2018 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import '../../../test/common-test-setup-karma.js';
-import './gr-keyboard-shortcuts-dialog.js';
-import {ShortcutSection} from '../../../mixins/keyboard-shortcut-mixin/keyboard-shortcut-mixin.js';
-
-const basicFixture = fixtureFromElement('gr-keyboard-shortcuts-dialog');
-
-suite('gr-keyboard-shortcuts-dialog tests', () => {
- let element;
-
- setup(() => {
- element = basicFixture.instantiate();
- });
-
- function update(directory) {
- element._onDirectoryUpdated(directory);
- flush();
- }
-
- suite('_left and _right contents', () => {
- test('empty dialog', () => {
- assert.strictEqual(element._left.length, 0);
- assert.strictEqual(element._right.length, 0);
- });
-
- test('everywhere goes on left', () => {
- update(new Map([
- [ShortcutSection.EVERYWHERE, ['everywhere shortcuts']],
- ]));
- assert.deepEqual(
- element._left,
- [
- {
- section: ShortcutSection.EVERYWHERE,
- shortcuts: ['everywhere shortcuts'],
- },
- ]);
- assert.strictEqual(element._right.length, 0);
- });
-
- test('navigation goes on left', () => {
- update(new Map([
- [ShortcutSection.NAVIGATION, ['navigation shortcuts']],
- ]));
- assert.deepEqual(
- element._left,
- [
- {
- section: ShortcutSection.NAVIGATION,
- shortcuts: ['navigation shortcuts'],
- },
- ]);
- assert.strictEqual(element._right.length, 0);
- });
-
- test('actions go on right', () => {
- update(new Map([
- [ShortcutSection.ACTIONS, ['actions shortcuts']],
- ]));
- assert.deepEqual(
- element._right,
- [
- {
- section: ShortcutSection.ACTIONS,
- shortcuts: ['actions shortcuts'],
- },
- ]);
- assert.strictEqual(element._left.length, 0);
- });
-
- test('reply dialog goes on right', () => {
- update(new Map([
- [ShortcutSection.REPLY_DIALOG, ['reply dialog shortcuts']],
- ]));
- assert.deepEqual(
- element._right,
- [
- {
- section: ShortcutSection.REPLY_DIALOG,
- shortcuts: ['reply dialog shortcuts'],
- },
- ]);
- assert.strictEqual(element._left.length, 0);
- });
-
- test('file list goes on right', () => {
- update(new Map([
- [ShortcutSection.FILE_LIST, ['file list shortcuts']],
- ]));
- assert.deepEqual(
- element._right,
- [
- {
- section: ShortcutSection.FILE_LIST,
- shortcuts: ['file list shortcuts'],
- },
- ]);
- assert.strictEqual(element._left.length, 0);
- });
-
- test('diffs go on right', () => {
- update(new Map([
- [ShortcutSection.DIFFS, ['diffs shortcuts']],
- ]));
- assert.deepEqual(
- element._right,
- [
- {
- section: ShortcutSection.DIFFS,
- shortcuts: ['diffs shortcuts'],
- },
- ]);
- assert.strictEqual(element._left.length, 0);
- });
-
- test('multiple sections on each side', () => {
- update(new Map([
- [ShortcutSection.ACTIONS, ['actions shortcuts']],
- [ShortcutSection.DIFFS, ['diffs shortcuts']],
- [ShortcutSection.EVERYWHERE, ['everywhere shortcuts']],
- [ShortcutSection.NAVIGATION, ['navigation shortcuts']],
- ]));
- assert.deepEqual(
- element._left,
- [
- {
- section: ShortcutSection.EVERYWHERE,
- shortcuts: ['everywhere shortcuts'],
- },
- {
- section: ShortcutSection.NAVIGATION,
- shortcuts: ['navigation shortcuts'],
- },
- ]);
- assert.deepEqual(
- element._right,
- [
- {
- section: ShortcutSection.ACTIONS,
- shortcuts: ['actions shortcuts'],
- },
- {
- section: ShortcutSection.DIFFS,
- shortcuts: ['diffs shortcuts'],
- },
- ]);
- });
- });
-});
-
diff --git a/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog_test.ts b/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog_test.ts
new file mode 100644
index 0000000..2c76704
--- /dev/null
+++ b/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog_test.ts
@@ -0,0 +1,156 @@
+/**
+ * @license
+ * Copyright (C) 2018 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import '../../../test/common-test-setup-karma';
+import {GrKeyboardShortcutsDialog} from './gr-keyboard-shortcuts-dialog';
+import {
+ SectionView,
+ ShortcutSection,
+} from '../../../mixins/keyboard-shortcut-mixin/keyboard-shortcut-mixin';
+
+const basicFixture = fixtureFromElement('gr-keyboard-shortcuts-dialog');
+
+suite('gr-keyboard-shortcuts-dialog tests', () => {
+ let element: GrKeyboardShortcutsDialog;
+
+ setup(() => {
+ element = basicFixture.instantiate();
+ });
+
+ function update(directory: Map<ShortcutSection, SectionView>) {
+ element._onDirectoryUpdated(directory);
+ flush();
+ }
+
+ suite('_left and _right contents', () => {
+ test('empty dialog', () => {
+ assert.isEmpty(element._left);
+ assert.isEmpty(element._right);
+ });
+
+ test('everywhere goes on left', () => {
+ const sectionView = [{binding: [], text: 'everywhere shortcuts'}];
+ update(new Map([[ShortcutSection.EVERYWHERE, sectionView]]));
+ assert.deepEqual(element._left, [
+ {
+ section: ShortcutSection.EVERYWHERE,
+ shortcuts: sectionView,
+ },
+ ]);
+ assert.isEmpty(element._right);
+ });
+
+ test('navigation goes on left', () => {
+ const sectionView = [{binding: [], text: 'navigation shortcuts'}];
+ update(new Map([[ShortcutSection.NAVIGATION, sectionView]]));
+ assert.deepEqual(element._left, [
+ {
+ section: ShortcutSection.NAVIGATION,
+ shortcuts: sectionView,
+ },
+ ]);
+ assert.isEmpty(element._right);
+ });
+
+ test('actions go on right', () => {
+ const sectionView = [{binding: [], text: 'actions shortcuts'}];
+ update(new Map([[ShortcutSection.ACTIONS, sectionView]]));
+ assert.deepEqual(element._right, [
+ {
+ section: ShortcutSection.ACTIONS,
+ shortcuts: sectionView,
+ },
+ ]);
+ assert.isEmpty(element._left);
+ });
+
+ test('reply dialog goes on right', () => {
+ const sectionView = [{binding: [], text: 'reply dialog shortcuts'}];
+ update(new Map([[ShortcutSection.REPLY_DIALOG, sectionView]]));
+ assert.deepEqual(element._right, [
+ {
+ section: ShortcutSection.REPLY_DIALOG,
+ shortcuts: sectionView,
+ },
+ ]);
+ assert.isEmpty(element._left);
+ });
+
+ test('file list goes on right', () => {
+ const sectionView = [{binding: [], text: 'file list shortcuts'}];
+ update(new Map([[ShortcutSection.FILE_LIST, sectionView]]));
+ assert.deepEqual(element._right, [
+ {
+ section: ShortcutSection.FILE_LIST,
+ shortcuts: sectionView,
+ },
+ ]);
+ assert.isEmpty(element._left);
+ });
+
+ test('diffs go on right', () => {
+ const sectionView = [{binding: [], text: 'diffs shortcuts'}];
+ update(new Map([[ShortcutSection.DIFFS, sectionView]]));
+ assert.deepEqual(element._right, [
+ {
+ section: ShortcutSection.DIFFS,
+ shortcuts: sectionView,
+ },
+ ]);
+ assert.isEmpty(element._left);
+ });
+
+ test('multiple sections on each side', () => {
+ const actionsSectionView = [{binding: [], text: 'actions shortcuts'}];
+ const diffsSectionView = [{binding: [], text: 'diffs shortcuts'}];
+ const everywhereSectionView = [
+ {binding: [], text: 'everywhere shortcuts'},
+ ];
+ const navigationSectionView = [
+ {binding: [], text: 'navigation shortcuts'},
+ ];
+ update(
+ new Map([
+ [ShortcutSection.ACTIONS, actionsSectionView],
+ [ShortcutSection.DIFFS, diffsSectionView],
+ [ShortcutSection.EVERYWHERE, everywhereSectionView],
+ [ShortcutSection.NAVIGATION, navigationSectionView],
+ ])
+ );
+ assert.deepEqual(element._left, [
+ {
+ section: ShortcutSection.EVERYWHERE,
+ shortcuts: everywhereSectionView,
+ },
+ {
+ section: ShortcutSection.NAVIGATION,
+ shortcuts: navigationSectionView,
+ },
+ ]);
+ assert.deepEqual(element._right, [
+ {
+ section: ShortcutSection.ACTIONS,
+ shortcuts: actionsSectionView,
+ },
+ {
+ section: ShortcutSection.DIFFS,
+ shortcuts: diffsSectionView,
+ },
+ ]);
+ });
+ });
+});
