| commit | 2afe3e308df0530155cb31e7dc5191dec86fce9e | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Tue Dec 08 09:14:24 2015 -0500 |
| committer | Dave Borowitz <dborowitz@google.com> | Tue Dec 08 09:14:24 2015 -0500 |
| tree | 974ebdaa71234ee352872bdff7678da7e1a23dfb | |
| parent | 2e66f80a4fbe351b9db885f2a34f790db836b31c [diff] |
ChangeUtil: Fix findChanges for anonymous users In I7710befa I didn't realize the user provider was a Provider<IdentifiedUser>, which caused a ProvisionException when anonymous users tried to use the REST API to look up changes by something other than a number. This wasn't noticed sooner because it didn't affect the web UI, which exclusively uses change numbers. Change to Provider<CurrentUser> and use asIdentifiedUser only at the sites where an IdentifiedUser is needed. This will throw a different unchecked exception type on failure (UnsupportedOperationException instead of ProvisionException), but callers aren't depending on that. Add a test, during which I also discovered a bug in the implementation of AbstractDaemonTest#setApiUserAnonymous. That wasn't already causing failures because the only user was using it to avoid some side effects that "may" have happened. Change-Id: Idbad114d6f5a61167d6fda32ee0093558491cf8e
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.