commit | e8810fbcb61a21e1242d466bb8f9845cf5bd1d67 | [log] [tgz] |
---|---|---|
author | Dave Borowitz <dborowitz@google.com> | Thu May 02 08:44:27 2019 -0700 |
committer | David Pursehouse <dpursehouse@collab.net> | Wed Jul 24 13:44:14 2019 +0900 |
tree | cb3dfdff46e4b448eb15787996e35849cf73f38e | |
parent | 413eb071d60aa672dbd358211d642635dc725fab [diff] |
Add assertThrows method compatible with future JUnit 4.13 The testing guidelines at Google have the following to say about testing for exceptions: "The strongly preferred solution is to use Assert.assertThrows(). ... In some situations you will decide it is important to check additional details about the thrown exception. You might care about its message, or the attributes of its chained exception, for example. It is easy to check these details, as assertThrows returns the thrown exception to you, and you can pass it to Truth. ... There are two cases where you can't use assertThrows: * In open-sourced code, until JUnit 4.13 is released. * When you aren't able to use Java 8 constructs like lambda expressions. (You can still use assertThrows, but you may find it bulky enough to outweigh its advantages.) However, use caution when doing so ... Don't use ExpectedException, @Test(expected =), or ExceptionExpectations. You can find a lengthy explanation of the pitfalls of these approaches in this page's history." I've mentioned these pitfalls in code reviews before, based on this advice. Paraphrasing the page history referenced above: * The main downside of manual try-fail is it's easy to forget the fail call; we've been bitten by this in Gerrit several times. * ExpectedException is dangerous because any statements after the throwing call will never be executed, even though the author of those statements probably did not intend this. * @Test(expected) passes if *any* statement in the test body throws, regardless of which statement the author had in mind. Later statements may not execute at all. Unfortunately, JUnit 4.13 is taking much longer to release than anticipated. I asked the Truth team approximately one year ago whether it would make sense to add assertThrows to Truth itself; their answer was that they didn't think it was worth it, given that it would eventually be replaced by JUnit 4.13. They told me that if we want to use it sooner, we should roll our own, so here we are. I wrote this method to be source-compatible with the method in JUnit 4.13 based upon reading the method signature and Javadoc of JUnit. However, I wrote the implementation from scratch without referencing the JUnit implementation. Change-Id: I4a774846ad6245f418c50be02dc469698b6e4def
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.