commit 29f95395d51fb215ea1eedfe07b0531064a1dda1
author David Ostrovsky <david@ostrovsky.org> Mon Aug 22 00:32:46 2016 +0200
committer David Ostrovsky <david.ostrovsky@gmail.com> Mon Aug 22 03:15:05 2016 +0000
tree 50b0a5230edc26835c2731cbe31a67d904f0b3e9
parent 7a54f8be788442cde5fe8b25022043f7c8597234

Plugin API: Provide custom manifest file

If no manifest file is specified, Buck's java_binary() rule merges the
content of manifest files from the dependant JARs into output
META/MANIFEST.MF. Normally we wouldn't care that it ends up with a lot
of mess, but unfortunately, it breaks the plugin-api.jar, with sealed
package exception, so we do care.

This happens because we provide the same package in multiple JARs, e.g.

  com.gerrit.server.project

is shipped with plugin-api.jar, obviously, but it happens that one file
Util.class, from the same package is shipped in the

  gerrit-acceptance-framework.jar

artifact. Normally it doesn't matter, unless a JAR is defined as sealed
in which case security violation exception is thrown during unit tests
execution.

To rectify this, we use the combination of custom manifest_file
attribute of java_binary() rule and passing non documented option from
this issue: [1] to ask Buck to not merge manifest files from the
dependant JARs.

With this fix, plugin unit tests executions in standalone build mode
work again.

* [1] https://github.com/facebook/buck/issues/86

Change-Id: I7b7571c20dcf6b54210b73760eccc8e699e6f1f6