commit 29e3289a377268b41b80a6c4fc87b410c2e3ef1b
author David Ostrovsky <david@ostrovsky.org> Sun Mar 09 19:30:48 2014 +0100
committer David Ostrovsky <david@ostrovsky.org> Mon Mar 10 07:42:51 2014 +0100
tree 4152f8efaca96b557a77bb263ad02de68671fc99
parent 65df1358a192fdeb75172a7b7e6061b5b57a6649

Protect reload plugin command with allow remote admin option

fd03350b9ea8af3cdf65fb8fb2367e333b252de4 introduced a new option
to disable remote plugin administration.

Require reloading plugins to be explicitly allowed with:

  plugins.allowRemoteAdmin = true

Change-Id: I2946202dd40af8b4197212fb15a488b166883d8a

gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/PluginReloadCommand.java

diff --git a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/PluginReloadCommand.java b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/PluginReloadCommand.java
index 8449160..4157515 100644
--- a/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/PluginReloadCommand.java
+++ b/gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/PluginReloadCommand.java
@@ -41,6 +41,9 @@
 
   @Override
   protected void run() throws UnloggedFailure {
+    if (!loader.isRemoteAdminEnabled()) {
+      throw die("remote plugin administration is disabled");
+    }
     if (names == null || names.isEmpty()) {
       loader.rescan();
     } else {