|author||Edwin Kempin <firstname.lastname@example.org>||Tue Jan 17 11:15:51 2023 +0100|
|committer||Edwin Kempin <email@example.com>||Tue Jan 17 12:21:22 2023 +0100|
Rework checking preconditions for rebase * Pull the permission check out of the RebaseUtil method that checks preconditions: * This allows us to do the permission check first in the rebase REST endpoints. If the calling user has no permissions to rebase, we should reject the request immediately and not open any resources (e.g. we should not open the repository). * This makes the permission checks more explicit which improves readability (the permission check is easy to miss if it’s done in a helper method). * To be on the safe side let RebaseChain still check the permission for every change in the chain (although this should not be necessary, since the rebase permission is assigned on the target branch the result of the permission evaluation should be the same for all changes in a chain). * Pull the checking whether the project is writable out of the RebaseUtil method that checks preconditions: This check needs to be done only once, but RebaseChain checked this once per change in the chain. * Make the RebaseUtil method that checks preconditions non-static: This way it can make use of the psUtil member variable and callers do not need to pass this in. * Remove unnecessary else in RebaseUtil#verifyRebasePreconditions. Release-Notes: skip Signed-off-by: Edwin Kempin <firstname.lastname@example.org> Change-Id: If8882684e88f1f5e44a7885d296b134911a06877
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.