commit 29a8cb0fe4e3fdb8d291c33bc5e97f2dc3bb9aab
author Edwin Kempin <ekempin@google.com> Thu Mar 09 15:55:16 2017 +0100
committer Edwin Kempin <ekempin@google.com> Thu Mar 09 15:56:43 2017 +0100
tree ef99a2464db023788a92142e60426ac599ac23a4
parent 2dbb936d16665aa8e3d2b087040dd0477429d28b

AuthInfo: Fix NullPointerException if there are no contributor agreements

The JavaScript exception is:

  SEVERE: (TypeError) : Cannot read property 'iterator' of null
  Class$S170: (TypeError) : Cannot read property 'iterator' of null
        at Unknown.$contributorAgreements(gerrit_ui-4.js)
        at Unknown.onLoad_19(gerrit_ui-4.js)
        at Unknown.onAttach_0(gerrit_ui-0.js)
        at Unknown.setParent(gerrit_ui-0.js)
        ...

Change-Id: I9de8ed23fbccf8987c871f36509f6f203a0ae73a
Signed-off-by: Edwin Kempin <ekempin@google.com>

gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AuthInfo.java

diff --git a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AuthInfo.java b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AuthInfo.java
index 2f6ef79..c0ece8c 100644
--- a/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AuthInfo.java
+++ b/gerrit-gwtui-common/src/main/java/com/google/gerrit/client/info/AuthInfo.java
@@ -67,8 +67,11 @@
 
   public final List<AgreementInfo> contributorAgreements() {
     List<AgreementInfo> agreements = new ArrayList<>();
-    for (AgreementInfo a : Natives.asList(_contributorAgreements())) {
-      agreements.add(a);
+    JsArray<AgreementInfo> contributorAgreements = _contributorAgreements();
+    if (contributorAgreements != null) {
+      for (AgreementInfo a : Natives.asList(contributorAgreements)) {
+        agreements.add(a);
+      }
     }
     return agreements;
   }