AccountResolver2: Expose more useful exception information Introduce a subclass of UnprocessableEntityException specific to this resolver code. Flesh out the error message in the ambiguous and inactive cases with the list of matching accounts, which is something end users have wanted for a long time. One reason we weren't able to provide this before was it was hard to reason about whether the multiple matching accounts were visible to the calling user. Now that we have stricter guarantees about visibility in the Result object, we know this is safe to do. Unfortunately, producing this exception message requires making Result non-static so we can pass through the injected AnonymousCowardName. This means we can't use AutoValue. However, neither downstream consumers nor tests were depending on any of the niceties of AutoValue. Nor should they be, really: AccountState is not immutable and doesn't implement equals. Rewriting the core search logic to keep track of inactive users makes it a bit more complicated, and at this point it makes more sense to inline the trySearch method. The complicated logic is hopefully balanced by good test coverage. Remove the Searcher field from Result. This wasn't providing much value in tests, since the searcher that matched is pretty well identified by the particular set of accounts that were returned. And now, with inactive users being combined across searchers, there's not necessarily a single searcher that identifies the result. Change-Id: I500fe32ade899d991ade90f90eaf5b8b83224a0d
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.