commit | 2da1fb65245b3ab6e1162493d3af3267d1783986 | [log] [tgz] |
---|---|---|
author | Ben Rohlfs <brohlfs@google.com> | Tue Jul 09 13:54:17 2019 +0200 |
committer | Ben Rohlfs <brohlfs@google.com> | Tue Jul 09 13:24:17 2019 +0000 |
tree | 10d66997b9b763f33d68c6586efc6daa203139f9 | |
parent | bab8a616f0de6013af5e1ac573484cad5bdaf45a [diff] |
Only use the externally set needs-review attribute in change-list-item This fixes issue 11085 where a lot of changes were bolded when using Polymer 2. I could not find a reason why gr-change-list-item should have an internal needsReview property and a _computeItemNeedsReview method. In Polymer 2 an undefined change.reviewed value would result in the needs-review attribute being added, even though gr-change-list may have set the attribute explicitly (and correctly!) from the outside. I have sent a question to the Polymer expert group about this, but I think the outcome of competing computes inside and outside is undefined at best. So the likely outcome is that we will just remove the internal compute. Bug: Issue 11085 Change-Id: I6d437562cb624e07454b8e32c0a051f8ef2ac182
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.