commit 2765ff9e5f821100e9ca671f4d502b5c938457a5
author Markus Heberling <markus@tisoft.de> Mon Aug 23 16:09:31 2010 +0200
committer Shawn O. Pearce <sop@google.com> Mon Aug 23 07:33:02 2010 -0700
tree 4b55cfd6f1e77c524aaa1d3c5266e25f23f142a8
parent 0d96f5b5b760442d9f3a749383cd8311f38d2654

Allow ; and & to seperate parameters in gitweb

gitweb allows parameters seperated with & and ;
Gerrit fails if parameters are seperated with &
This small patch fixes this issue.

Change-Id: I216164d3bb6df6724c6fe7257a9c1d946a96520a

gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebServlet.java

diff --git a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebServlet.java b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebServlet.java
index 957e088..a704476 100644
--- a/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebServlet.java
+++ b/gerrit-httpd/src/main/java/com/google/gerrit/httpd/gitweb/GitWebServlet.java
@@ -354,7 +354,7 @@
   private static Map<String, String> getParameters(final HttpServletRequest req)
       throws UnsupportedEncodingException {
     final Map<String, String> params = new HashMap<String, String>();
-    for (final String pair : req.getQueryString().split(";")) {
+    for (final String pair : req.getQueryString().split("[&;]")) {
       final int eq = pair.indexOf('=');
       if (0 < eq) {
         String name = pair.substring(0, eq);