commit | 272a803f38a935feca410dc7683cf2d37f40f409 | [log] [tgz] |
---|---|---|
author | Patrick Hiesel <hiesel@google.com> | Tue May 30 16:48:48 2017 +0200 |
committer | Patrick Hiesel <hiesel@google.com> | Tue Jul 11 17:18:10 2017 +0200 |
tree | 5ea64a6405de25408a8d4c9e6f449b0b281e51bd | |
parent | b771e8d2e0dc976f7ecb8e5f8259d9789006ee24 [diff] |
Rewrite GWT UI to use project name in addition to numeric change ID This change adapts the GWT UI to recognize a project name in the URL alongside the numeric change ID and integrate it into all REST API calls made on /changes. This is an effort towards having the project in all REST API calls to /changes which will make routing Gerrit requests easier. On top, it doesn't require secondary index lookups for trivial calls like /detail. In contrast to the original proposal, changes will be served at /c/project-name/+/123 instead of /p/project-name/+c/1234. This is to stay more consistent with the REST API which serves all changes at /changes instead of /projects. The only difference between the UI and the API is now that the UI uses '/+/' as a delimiter while the API uses '~'. In addition project names in the API need to be URL encoded. This enables us to use the new change id that includes the project also in a later part of the URL. In the UI, this isn't needed and at the same time we want to maximize the readability of URLs which is done by the two differences noted above. If a user uses a URL without the project (/c/123), we retrieve the project upon the first API call and rewrite the URL. All instances of Project.NameKey and String project are marked @Nullable where they can actually be null. In the API layer they are consistently marked @Nullable to reflect the current status of the backend. That is, a project can optionally be provided. This might be changed to a more strict policy at a later stage. Change-Id: Ie3feee2e3b3e3b91b8d646d0326b7ada6134a0f9
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.