commit | 2712c24a0615407b1c2515fab09e92eaf8de25f7 | [log] [tgz] |
---|---|---|
author | Ben Rohlfs <brohlfs@google.com> | Tue May 11 17:00:53 2021 +0200 |
committer | Ben Rohlfs <brohlfs@google.com> | Wed May 12 10:52:36 2021 +0200 |
tree | 149b1b564475cd7c51f49a2dc7e80de866d76b8e | |
parent | fbd7d977fb963f0fdfa2add20b4512d352d2a59b [diff] |
Do not process keyboard shortcuts for invisible views Since change 305575 the change- and diff-views are not destroyed anymore, but stay around invisibly as long as the change number does not change. This broke keyboard shortcut handling, because the handlers of the invisible views were competing with the handlers from of the visible ones. This change enhances the keyboard shortcut mixin to not just run the setup and destroy code on element connect and disconnect, but also when the visibility of the view changes. Bug: Issue 14522 Change-Id: I4e7c49ea26861f4e11faa6826a6e710366523075
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.