| commit | 1ad7bcdda6f1d76e25aa1580e3cc9febd69bbf0c | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Mon Jun 26 12:53:41 2023 +0200 |
| committer | Paladox none <thomasmulhall410@yahoo.com> | Mon Jun 26 15:21:00 2023 +0000 |
| tree | cfadaa80b155144127ccae09d074e2b96295a560 | |
| parent | 54d3515b81a1882b124eceeaf21e70c1f9baf17c [diff] |
Fix browser freeze for large number of check results
In the `collectRunResults()` reducer function we are collecting the
results of all runs into one array. For conveniently working with check
results we have a RunResult type that allows access to the run
properties in every result. This is super useful, because the run holds
a lot of basic information that we don't want to repeat in every result,
but we also don't want to look up the run from the result every time.
Just spreading `{...run, ...result}` into one object is problematic,
because the object will also contain the full `results` array of the
run. Thus when reducing runs with 1,000 results we are getting an
object that contains 1,000,000 results.
In the referenced bug the web app had to handle 11,000 check results,
which froze the browser because of this issue with reducing into one
flat list.
Let's just remove the `results` from all the `RunResult` objects and
enforce that in the type. And also add a test.
Release-Notes: skip
Google-Bug-Id: b/288305912
Change-Id: If3ba5717347f29566e1702812e1a70f2d5f0a234
(cherry picked from commit 68b472376bdb920477c70fa5bfdcc71d2ed75875)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.