| commit | 25fb0caa661c41c2a546b017da11fe8edb7c4dcb | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Wed Sep 27 09:12:48 2017 -0400 |
| committer | Dave Borowitz <dborowitz@google.com> | Sat Sep 30 10:05:56 2017 -0400 |
| tree | 899e0a5cd09bdd43b8c32ca0db482694f3c01414 | |
| parent | 6a9777722b91333cc688bfb77e7129a3861113ca [diff] |
ChangeStatusPredicate: Silently ignore invalid status Instead of throwing an exception from the ChangeStatusPredicate constructor complaining about an invalid change status, return a real index predicate that is guaranteed to match no changes in the index. This is similar to the behavior of other query engines that are vaguely Gerrit-like; for example, in Gmail, searching for [has:attachment] has meaning, whereas [has:fhqwhgads] successfully returns no results. The proximate motivation for this change is so user dashboards and other links containing [is:draft] predicates continue to work after removing the draft workflow. While it might be reasonable to return 400 for a pure [is:draft] search after drafts are removed, a user might expect [owner:self (is:draft OR is:new)] to continue working. Similarly, we can write a migration that removes all [is:draft] custom dashboard entries from user preferences, but there is no single migration step that works in the general case of a query containing [is:draft] at arbitrary points in the query tree. This change is straightforward and general, but is not the only way to achieve this goal. Another possibility would be to special-case [is:draft] specifically to return ChangeStatusPredicate.NONE. That would be the most minimal behavior change, but requires more messy hard-coding. Change-Id: I32119ff660d914a64da64bcd0769b0434d68a8d6
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.