commit 40d5e710c9154f0075be9f5370aa38c098235a8f
author Gal Paikin <paiking@google.com> Sun Nov 07 18:51:47 2021 +0100
committer Gal Paikin <paiking@google.com> Thu Nov 11 14:56:20 2021 +0100
tree 68eed3951b3ddfb6e16762d1ce889e94f3ddfdca
parent 2f4985084e391982bd1805e489a0d52eba9397ef

Fix post submit diff size limit

The change index has a limit for the cumulative size of comments for
each change. At Google, the limit is 5MB. The cumulative comment size
that is default and is set at Google is 3MB, which provides a buffer of
2MB for things that don't count against the limit. Post Submit Diff is
an example for something that doesn't count against the limit.

In the 2 follow-up changes, we will count autogenerated messages and the
post submit diff as part of the limit.

Hence, we fix the maximum size of this post submit diff to be a tenth of
the cumulative size limit that is set (by default that would be 300KB).

That way, there is no danger of surpassing the "real" maximum which is
5MB.

While at it, we also adjust/fix some of the tests about those limits.

Additionally:
1. We do not filter change messages on CommentCumulativeSizeValidator.
2. We check on post submit diff that we do not exceed the limit (and not
just "not exceed 10% of the limit").

Change-Id: Ic67e06dbc2f6330519837e1644a3a2fab2110c59